Engine roll to the framework failing on macros package version issue about flutter HOT 13 CLOSED

Previously: #148004

cc @christopherfujino @jakemac53 @scheglov @gspencergoog

Handling this by reverting the Dart SDK and stopping Dart -> Engine rolls so that the Engine -> Framework rolls do not remain blocked over the whole long weekend.

from flutter.

From @jakemac53 over chat:

You will need the next version of analyzer (6.5.1, to be published soon)

from flutter.

Correct, for the next engine -> flutter roll to succeed (once it includes dart-lang/sdk@77490aa), there will need to be an atomic roll of analyzer from 6.5.0 to 6.5.1.

We would not need an atomic update here if we can instead do a version constraint such as >=6.5.0 <6.5.2 on the analyzer in flutter/flutter packages.

The reason for this is analyzer implements APIs which come from an SDK vendored package (package:_macros ultimately), and a new method was added to a class that the analyzer implements. It has dependency constraints to guarantee compatibility, but since it is pinned the version has to be explicitly updated when the Dart SDK is updated.

from flutter.

Published https://pub.dev/packages/analyzer/versions/6.5.1

from flutter.

(triage) @eyebrowsoffire I believe you're the engine sheriff. Could you bump the version of the analyzer to 6.5.1 with the next engine roll?

from flutter.

Dart with the breaking change has to be rolled into the engine first, then the analyzer version bump has to land in a manual roll at the same time as rolling the engine with the new Dart version.

from flutter.

I'm on it. We had other breakages blocking the roll yesterday, but I think we should be able to get this through today.

from flutter.

Note that there was an accidental change that landed in that version, which requires another breaking change to roll back, so this will happen again soon.... apologies.

I could likely land things today, if you want to wait a bit longer and do a single roll.

from flutter.

It sounds like we need a system for making changes to package:macros that allows automatic engine rolls. And the current system does not allow that, is that right?

I want to let everyone focus on fixing today's immediate issue here, and I've opened a separate issue for what to do moving forward: dart-lang/sdk#55870

from flutter.

In #149263, rolling the framework packages forward to pick up the new analyzer has also brought in what look like new versions of plugins for some integration tests which are now failing on CI, as in:

https://ci.chromium.org/ui/p/flutter/builders/try/Mac_arm64%20build_tests_1_4/7440/overview

We should decouple the plugin updates from the analyzer package updates.

from flutter.

Can this issue be closed ?
Improvements to the process of making changes package:macros is being tracked in dart-lang/sdk#55870

from flutter.

This particular issue has been fixed, though the roll is blocked for new reasons.

from flutter.

This particular issue has been fixed, though the roll is blocked for new reasons.

I presume you are referring to the dart2wasm compilation errors issues, it being tracked in #149600

from flutter.