Comments (8)
AriasBros
commented on July 20, 2024
1
Thanks @huycozy, very appreciated.
This issue is a block for our product (we can't send the module to our partners/customers to integrate with our product) so I sent a PR with your suggestion of fix to the Flutterfire project.
from flutter.
AriasBros
commented on July 20, 2024
1
Hi @vashworth
Yes, after that fix the module can be built and both flutter run and flutter build ios-framework are working as expected now.
from flutter.
vashworth
commented on July 20, 2024
1
Hi @vashworth
Yes, after that fix the module can be built and both
flutter runandflutter build ios-frameworkare working as expected now.
Excellent! Thank you for fixing and confirming!
from flutter.
huycozy
commented on July 20, 2024
Hi @AriasBros
This should be fixed on the plugin side. The current version of firebase_app_check uses <angle> include instead of quotes, see https://github.com/firebase/flutterfire/blob/master/packages/firebase_app_check/firebase_app_check/ios/Classes/FLTFirebaseAppCheckPlugin.h#L5-L13.
For reference on a similar fix for 1st party package image_picker: https://github.com/flutter/plugins/pull/5635/files.
Meanwhile, you can try a workaround from this answer.
Please report the issue on flutterfire repository for better support there. Closing the issue. If you disagree, please write in the comments and I will reopen it. Thanks!
from flutter.
AriasBros
commented on July 20, 2024
Hi @huycozy, thanks for your response.
This should be fixed on the plugin side
Well, I put here the issue because as I mentioned in the description, a Flutter app works when using firebase_app_check, while a Flutter module doesn't work. So it seems like there is something different between the iOS project of a Flutter module and the iOS project of a Flutter app.
Meanwhile, you can try a workaround from this answer.
Before send this issue I already checked that workaround, even when in an iOS project of a Flutter module that could mean to apply a temporary fix every time the .ios is recreated by Flutter. But in this case, it is not working.
If you disagree...
I am not totally disagree with close the issue, and I feel that the right solution here is to modify and fix firebase_app_check.
But, if a Flutter application works already with the current version of firebase_app_check, I think the right behavior of a Flutter module should work too with the same firebase_app_check version. And it is not the case here.
If you do this:
- Create a new Flutter app:
flutter create angled_error_app - Install the package firebase_app_check:
flutter pub add firebase_app_check - If installing the latest version of firebase_app_check (0.3.0), change the iOS deployment target to version 13.
- Run the app for iOS:
flutter run
This will work with no problem. The default counter app will appear in your iOS simulator/device.
But, if you change the first step by flutter create --template module angled_error_module and you try to run the module, you will not see the default counter app because the build fails before.
Anyway, I will open an issue in Flutterfire too, linking to this issue.
Thanks.
from flutter.
huycozy
commented on July 20, 2024
So it seems like there is something different between the iOS project of a Flutter module and the iOS project of a Flutter app.
I have also checked on Flutter app and see this difference between it and module type; app can run normally without issue. I'd like to know if there is anything that can be intervened on Flutter tool side, I will re-open and label this for other's input. Thank you for opening an issue on flutterfire too.
flutter doctor -v (stable and master)
[✓] Flutter (Channel stable, 3.22.2, on macOS 14.1 23B74 darwin-x64, locale en-VN)
• Flutter version 3.22.2 on channel stable at /Users/huynq/Documents/GitHub/flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 761747bfc5 (31 hours ago), 2024-06-05 22:15:13 +0200
• Engine revision edd8546116
• Dart version 3.4.3
• DevTools version 2.34.3
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
• Android SDK at /Users/huynq/Library/Android/sdk
• Platform android-34, build-tools 34.0.0
• ANDROID_HOME = /Users/huynq/Library/Android/sdk
• Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 15.3)
• Xcode at /Applications/Xcode15.3.app/Contents/Developer
• Build 15E204a
• CocoaPods version 1.15.2
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 2023.3)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• android-studio-dir = /Applications/Android Studio.app/
• Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160)
[✓] VS Code (version 1.89.1)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.90.0
[✓] Connected device (3 available)
• iPhone (mobile) • d9a94afe2b649fef56ba0bfeb052f0f2a7dae95e • ios • iOS 15.8 19H370
• macOS (desktop) • macos • darwin-x64 • macOS 14.1 23B74 darwin-x64
• Chrome (web) • chrome • web-javascript • Google Chrome 125.0.6422.142
[✓] Network resources
• All expected network resources are available.
• No issues found![!] Flutter (Channel master, 3.23.0-13.0.pre.168, on macOS 14.1 23B74 darwin-x64, locale en-VN)
• Flutter version 3.23.0-13.0.pre.168 on channel master at /Users/huynq/Documents/GitHub/flutter_master
! Warning: `flutter` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
! Warning: `dart` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 32081aab69 (34 hours ago), 2024-06-08 10:35:21 -0700
• Engine revision 1cdbebee19
• Dart version 3.5.0 (build 3.5.0-236.0.dev)
• DevTools version 2.36.0
• If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
• Android SDK at /Users/huynq/Library/Android/sdk
• Platform android-34, build-tools 34.0.0
• ANDROID_HOME = /Users/huynq/Library/Android/sdk
• Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 15.3)
• Xcode at /Applications/Xcode15.3.app/Contents/Developer
• Build 15E204a
• CocoaPods version 1.15.2
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 2023.3)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• android-studio-dir = /Applications/Android Studio.app/
• Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160)
[✓] VS Code (version 1.89.1)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.90.0
[✓] Connected device (4 available)
• Pixel 7 (mobile) • 2B171FDH20084L • android-arm64 • Android 14 (API 34)
• iPhone (mobile) • d9a94afe2b649fef56ba0bfeb052f0f2a7dae95e • ios • iOS 15.8 19H370
• macOS (desktop) • macos • darwin-x64 • macOS 14.1 23B74 darwin-x64
• Chrome (web) • chrome • web-javascript • Google Chrome 125.0.6422.142
[✓] Network resources
• All expected network resources are available.
! Doctor found issues in 1 category.from flutter.
vashworth
commented on July 20, 2024
@AriasBros After your changed firebase/flutterfire#12929 landed, did this fix it for you in the module?
from flutter.
github-actions
commented on July 20, 2024
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
from flutter.
Related Issues (20)
- [flutter web] A highlight of characters is incorrect on composing mode at TextFiled.
- Linux applications show black screen at start-up in debug mode HOT 9
- FAB above snackbar
- [flutter web] When converting characters from hiragana to kanji, the display is distorted at TextFiled. HOT 1
- HtmlElementView does render correct scale on wasm HOT 1
- [tool_crash] FileSystemException: Cannot create file, OS Error: Access is denied., errno = 5 HOT 1
- mac-14 lost external connection phone device. HOT 2
- mac-12 lost external connection phone device. HOT 2
- linux-45 lost external connection phone device. HOT 2
- mac-7 lost external connection phone device. HOT 1
- mac-25 lost external connection phone device. HOT 2
- Not possible to run some android tests in presubmit even when modifying ci.yaml HOT 2
- Ignore the `.patch` files from `third_party/icu` in license checker HOT 2
- `TextCapitalization.words` doesn't work on `Web` using iOS devices HOT 2
- [Impeller] Investigate if the minimum OpenGL ES version can raised to ES 3.0 (or higher?). HOT 1
- mac-26 lost external connection phone device.
- Impeller only: Clipping a Column doesn't work properly when Column contains a BackdropFilter HOT 2
- Could not resolve all files for configuration 'classpath': Could not resolve com.google.gms:google-services:4.4.2. HOT 7
- LUCI recipe_engine has not rolled to flutter/recipes since April HOT 3
- minified:apv Null check operator used on a null value HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from flutter.