Giter VIP home page Giter VIP logo

Comments (10)

huycozy avatar huycozy commented on July 22, 2024

Hi @polina-c
I checked this using basic_markdown_demo sample code which loads an asset as ![import](assets/logo.png) but I see the logo.png still is displaying on both debug and release modes.

Can you provide more clues to reproduce this issue?

from flutter.

polina-c avatar polina-c commented on July 22, 2024

Sure!
Steps to repro:

  1. Checkout https://github.com/flutter/devtools at 40b9a2ccfe98bcbfa5751ce24dc68b9cdc004acf
  2. cd packages/devtools_app
  3. Run dart run benchmark/scripts/run_benchmarks.dart
  4. See it is passing
  5. Find in code and replace const imagePath = isWebProd ? 'assets/' : ''; with const imagePath = ''
  6. Run the script again
  7. See it fails with error, while it is expected not to fail:
Unrecognized URL path: /assets/img/doc/upload_dark.png
Unhandled exception:
Caught browser-side error: Instance of 'ProgressEvent'
  1. Run flutter run -d chrome
  2. In opened Chrome navigate to Memory tab
  3. Find the arrow rendered:
Screenshot 2024-06-07 at 10 12 18 AM

9 . Run:

flutter build web --release --no-tree-shake-icons
cd build/web
python3 -m http.server 8000
  1. Open http://localhost:8000/home
  2. Navigate to Momory tab
  3. See the arrow is not here

from flutter.

polina-c avatar polina-c commented on July 22, 2024 
Flutter 3.23.0-12.0.pre • channel [user-branch] • unknown source
Framework • revision 35ae519140 (10 days ago) • 2024-05-29 00:33:07 -0400
Engine • revision b26e1b023c
Tools • Dart 3.5.0 (build 3.5.0-191.0.dev) • DevTools 2.36.0-dev.10

from flutter.

polina-c avatar polina-c commented on July 22, 2024

I am on Apple M1 Pro

from flutter.

polina-c avatar polina-c commented on July 22, 2024

Hi @polina-c I checked this using basic_markdown_demo sample code which loads an asset as ![import](assets/logo.png) but I see the logo.png still is displaying on both debug and release modes.

Can you provide more clues to reproduce this issue?

May be basic example will repro if you serve web, not just do flutter run ...:

flutter build web --release --no-tree-shake-icons
cd build/web
python3 -m http.server 8000

from flutter.

huycozy avatar huycozy commented on July 22, 2024

Thanks for your update, @polina-c. I can't reproduce this with basic_markdown_demo sample code (non-edited version) but I can reproduce with devtools as shared above. Labeling the issue for input from others.

Screenshot 2024-06-10 at 14 54 49

flutter doctor -v 
[!] Flutter (Channel master, 3.23.0-13.0.pre.168, on macOS 14.1 23B74 darwin-x64, locale en-VN)
    • Flutter version 3.23.0-13.0.pre.168 on channel master at /Users/huynq/Documents/GitHub/flutter_master
    ! Warning: `flutter` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 32081aab69 (34 hours ago), 2024-06-08 10:35:21 -0700
    • Engine revision 1cdbebee19
    • Dart version 3.5.0 (build 3.5.0-236.0.dev)
    • DevTools version 2.36.0
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.3)
    • Xcode at /Applications/Xcode15.3.app/Contents/Developer
    • Build 15E204a
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • android-studio-dir = /Applications/Android Studio.app/
    • Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160)

[✓] VS Code (version 1.89.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.90.0

[✓] Connected device (4 available)
    • Pixel 7 (mobile) • 2B171FDH20084L                           • android-arm64  • Android 14 (API 34)
    • iPhone (mobile)  • d9a94afe2b649fef56ba0bfeb052f0f2a7dae95e • ios            • iOS 15.8 19H370
    • macOS (desktop)  • macos                                    • darwin-x64     • macOS 14.1 23B74 darwin-x64
    • Chrome (web)     • chrome                                   • web-javascript • Google Chrome 125.0.6422.142

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

from flutter.

stuartmorgan avatar stuartmorgan commented on July 22, 2024

@polina-c Is this actually related to flutter_markdown, or is it a general assets behavior and this specific repro just happens to use flutter_markdown?

from flutter.

polina-c avatar polina-c commented on July 22, 2024

@polina-c Is this actually related to flutter_markdown, or is it a general assets behavior and this specific repro just happens to use flutter_markdown?

There is no issues with other images in DevTools, rendered without markdown.

from flutter.

yjbanov avatar yjbanov commented on July 22, 2024

I think this is a duplicate of #86833

from flutter.

github-actions avatar github-actions commented on July 22, 2024

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

from flutter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.