[quick_actions_ios] Xcode 16 beta 1: extension declares a conformance of imported type 'FlutterError' to imported protocols 'Error', 'Sendable' about flutter HOT 12 CLOSED

@tarrinneal do you know how this extension code is generated? I'm not spotting it in pigeon
https://github.com/flutter/packages/blob/937038cd033d2c468f871a338ec893343a09ca04/packages/quick_actions/quick_actions_ios/ios/quick_actions_ios/Sources/quick_actions_ios/messages.g.swift#L17

extension FlutterError: Error {}

In Xcode 16.0 beta 1 it seems to want this to be "fully qualified" :

extension FlutterError: Swift.Error {}

The implication is that generated pigeon Swift files with this pattern will generate a compilation warning.

from flutter.

That line has changed, but the current version of it is here: https://github.com/flutter/packages/blob/937038cd033d2c468f871a338ec893343a09ca04/packages/pigeon/lib/swift_generator.dart#L842

from flutter.

@hellohuanlin

from flutter.

That line has changed, but the current version of it is here: https://github.com/flutter/packages/blob/937038cd033d2c468f871a338ec893343a09ca04/packages/pigeon/lib/swift_generator.dart#L842

You're saying the extension code isn't generated any more by pigeon? Does that mean I should just regenerate the code for this particular plugin?

from flutter.

It was never generated by Pigeon, it was something we recommended people do at the plugin level in Swift plugins in older versions of Pigeon. I can fix this in the plugin.

from flutter.

It was never generated by Pigeon, it was something we recommended people do at the plugin level in Swift plugins in older versions of Pigeon. I can fix this in the plugin.

So this wasn't "Autogenerated from Pigeon (v12.0.1), do not edit directly."? It was edited?

from flutter.

That extension was added manually, but we've since switched to using our own PigeonError instead. I'm not sure if that class needs the new code (probably does)

from flutter.

you can see the old recommendations here packages/pigeon/example/README.md
(this is the pr that added the new error class)

from flutter.

I see, thanks for the clarification. I thought this code was autogenerated so required a pigeon update.

from flutter.

It should have been added in the code that used it rather than the generated file. We might have thought we were going to add it to the generator at that point?

But it turns out we aren't even using FlutterError in that plugin, so I'm not sure why it ended up in the PR at all 🤷🏻

from flutter.

Thank you @stuartmorgan and @tarrinneal!

from flutter.

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

from flutter.