Comments (12)
@tarrinneal do you know how this extension
code is generated? I'm not spotting it in pigeon
https://github.com/flutter/packages/blob/937038cd033d2c468f871a338ec893343a09ca04/packages/quick_actions/quick_actions_ios/ios/quick_actions_ios/Sources/quick_actions_ios/messages.g.swift#L17
extension FlutterError: Error {}
In Xcode 16.0 beta 1 it seems to want this to be "fully qualified" :
extension FlutterError: Swift.Error {}
The implication is that generated pigeon Swift files with this pattern will generate a compilation warning.
from flutter.
That line has changed, but the current version of it is here: https://github.com/flutter/packages/blob/937038cd033d2c468f871a338ec893343a09ca04/packages/pigeon/lib/swift_generator.dart#L842
from flutter.
from flutter.
That line has changed, but the current version of it is here: https://github.com/flutter/packages/blob/937038cd033d2c468f871a338ec893343a09ca04/packages/pigeon/lib/swift_generator.dart#L842
You're saying the extension
code isn't generated any more by pigeon? Does that mean I should just regenerate the code for this particular plugin?
from flutter.
It was never generated by Pigeon, it was something we recommended people do at the plugin level in Swift plugins in older versions of Pigeon. I can fix this in the plugin.
from flutter.
It was never generated by Pigeon, it was something we recommended people do at the plugin level in Swift plugins in older versions of Pigeon. I can fix this in the plugin.
So this wasn't "Autogenerated from Pigeon (v12.0.1), do not edit directly."? It was edited?
from flutter.
That extension was added manually, but we've since switched to using our own PigeonError
instead. I'm not sure if that class needs the new code (probably does)
from flutter.
you can see the old recommendations here packages/pigeon/example/README.md
(this is the pr that added the new error class)
from flutter.
I see, thanks for the clarification. I thought this code was autogenerated so required a pigeon update.
from flutter.
It should have been added in the code that used it rather than the generated file. We might have thought we were going to add it to the generator at that point?
But it turns out we aren't even using FlutterError
in that plugin, so I'm not sure why it ended up in the PR at all 🤷🏻
from flutter.
Thank you @stuartmorgan and @tarrinneal!
from flutter.
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v
and a minimal reproduction of the issue.
from flutter.
Related Issues (20)
- Windows build_tests_1_7 is 2.00% flaky
- Linux customer_testing is 3.00% flaky HOT 2
- Mac channels_integration_test is 2.02% flaky HOT 7
- Mac platform_channel_sample_test_macos is 2.02% flaky
- [go_router] unexpected pop animiaton HOT 4
- go_router All pages in the stack are rebuilt every time a push or pop is made.
- Better postmortem analysis support HOT 1
- [native_assets] `flutter clean` should delete all native assets HOT 2
- Wrong positioned Expanded hangs the UI in Release while it just show an error in Debug mode HOT 2
- DropdownMenu is showing black background when first opened on Linux (only on latest stable, in master it has been fixed it seems) HOT 4
- Range start 4 is out of text of length 1 HOT 1
- mac-1 lost external connection phone device. HOT 2
- linux-62 lost external connection phone device. HOT 1
- linux-13 lost external connection phone device. HOT 2
- mac-28 lost external connection phone device. HOT 1
- mac-28 lost external connection phone device. HOT 2
- mac-8 lost external connection phone device. HOT 1
- Flutter Web Deeplink dosen't work HOT 1
- firstWhere stuck in infinite loop HOT 3
- unavailable MainAxisAlignment HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from flutter.