Comments (7)
There was another regression that was reported for that roll here: https://flutter-flutter-perf.skia.org/e/?begin=1719260348&end=1719335402&keys=X9bbdf72b97d78666cbdd3111fa2634b5&selected=commit%3D41333%26name%3D%252Carch%253Dintel%252Cbranch%253Dmaster%252Cconfig%253Ddefault%252Cdevice_type%253DMoto_G__4_%252Cdevice_version%253Dnone%252Chost_type%253Dmac%252Csub_result%253Dcompute_iteration%252Ctest%253Dmicrobenchmarks%252C&xbaroffset=41333
Jason identified https://dart.googlesource.com/sdk/+/452de7b0980a76917a6c0a4669bf3e68f645d00d as the point where the regression started and the Dart team was notified.
from flutter.
@gaaclarke The first regression listed here bench_update_many_child_layers.canvaskit.drawFrameDuration.outlierRatio
is in Flutter for Web or Native Flutter ?
from flutter.
@gaaclarke The first regression listed here
bench_update_many_child_layers.canvaskit.drawFrameDuration.outlierRatio
is in Flutter for Web or Native Flutter ?
That's in flutter web.
from flutter.
Tried bisecting engine builds in that range.
This benchmark is noisy, but the benchmark change appears to be correlated with flutter/engine@e41a8c2 (which contains https://dart.googlesource.com/sdk/+/1c534e5fd5e5c001ac586bbac9e7e3e20569ddcd)
from flutter.
Hmm, I can't really tell how that CL could translate to the resulting benchmark regression, but I'll need to try it locally. I thought maybe the variance is higher due to a lower average, but the benchmark for average hasn't changed (drawFrameDuration
at least, totalUiFrame
might have decreased however?). Is the next step here for me to revert?
from flutter.
In my local runs I saw significantly higher values for bench_update_many_child_layers.canvaskit.drawFrameDuration.outlierAverage
with that Dart roll.
But the average
on that same benchmark did not show a major change after the Dart roll.
So the increased outlierAverage
versus the similar average
means a higher outlierRatio
.
(I haven't worked with the internals of these web benchmarks before and have not tried capturing the full set of frame times. Possibly something changed in the distribution of frames that are classified as outliers.)
AFAIK there have not been other alerts on Flutter's performance dashboard associated with this roll. And in my local runs of web_benchmarks_canvaskit
I did not notice any other regressions in the metrics.
So a revert may not be necessary - so far I have not seen evidence of a broader issue. But I'd be curious to understand why that change would affect this particular workoad.
from flutter.
So a revert may not be necessary - so far I have not seen evidence of a broader issue.
Got it. Let me know if that changes.
But I'd be curious to understand why that change would affect this particular workoad.
Yeah, I'm not seeing anything that could tie the two together. I'd need to determine where calls from the benchmark flow to .toJS
calls. The only thing I can think of that might lead to a greater variance is if for some reason the benchmark ends up calling different arity callbacks across runs. The Dart change speeds up performance for 0-5 argument callbacks much more than it does 5+ argument callbacks. But then we'd see a lower average and not just a higher outlier ratio, so I doubt that's the case.
from flutter.
Related Issues (20)
- Add a CupertinoCollapsible widget HOT 5
- [CP] Fix BaseTapAndDragGestureRecognizer drag state after losing gesture arena
- Error: Uncaught TypeError: Cannot read properties of undefined (reading 'load') for index.html HOT 1
- IntelliJ is not recognized as IDE (cannot set Java version) [macos] HOT 2
- mac-23 lost external connection phone device. HOT 1
- mac-7, mac-24 and mac-2 lost external connection phone device. HOT 1
- mac-1 and mac-14 lost external connection phone device. HOT 1
- [CP] Fix deleting text in `EditableText` with CJK keyboard while in `CupertinoPageRoute` throws exception
- mac-3 lost external connection phone device. HOT 1
- CupertinoButton doesn't expose a long press handler (onLongPress)
- `PredictiveBackPageTransitionsBuilder` background color not changeable HOT 1
- Impeller breaks mesh gradients HOT 5
- [Android, iOS] Write integration tests to test `SystemUiMode` expected behavior HOT 1
- [ios 18] Launching debug mode app from the home screen (not from the debugger) segfault crashes on launch at `-createTouchRateCorrectionVSyncClientIfNeeded` HOT 5
- `HttpException: Connection closed before full header was received, uri = http://localhost:52097/json` HOT 1
- ☂️ HTML renderer post-deprecation tasks HOT 1
- The documented CI Flutter build mechanism does not include iOS entitlements HOT 5
- Devicelab microbenchmarks too large? HOT 2
- AlertDialog.adaptive.clipBehavior is non-nullable HOT 4
- Isolates are taking more memory than expected HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from flutter.