sky.ColorFilter needs operator== about flutter HOT 6 CLOSED

Comment by Hixie
Thursday Jul 16, 2015 at 22:25 GMT

From @eseidel on July 16, 2015 4:19

Would be nice to be able to catch these errors in some way. In obj-c one could override -[NSObject equals:] to warn using a "category". I know dart doesn't have those, but maybe there is another solution we should use.

from flutter.

Comment by Hixie
Monday Oct 26, 2015 at 05:05 GMT

@abarth You said you were planning on changing how this works so that ColorFilter would be a pure Dart class, right? With the data sent over to the C++ in an efficient manner at the last minute?

from flutter.

Comment by abarth
Monday Oct 26, 2015 at 05:24 GMT

That's right. The steps are:

• Start using the new binding system for window, replacing view.
• Switch the Canvas interface over to the new bindings system.
• Lift Paint-related classes up into Dart using the new bindings system.

from flutter.

It looks like ColorFilter is still a wrapped native:
https://github.com/flutter/engine/blob/master/sky/engine/core/painting/ColorFilter.h

from flutter.

Fixed!

from flutter.

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

from flutter.