checking for cffi.__version_info__ >= (1,1) in python module cffi... no about flux-core HOT 9 CLOSED

I think we're trying to avoid adding a new dependency.

True, we don't need it today. I guess I was thinking longer out we would. But we can leave that for another time.

from flux-core.

i guess packaging is not a native python lib/module? extra?

>python3.6
Python 3.6.8 (default, May 31 2023, 10:28:59) 
[GCC 8.5.0 20210514 (Red Hat 8.5.0-18)] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import packaging
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ModuleNotFoundError: No module named 'packaging'
>>> import distutils
>>> 

from flux-core.

yup, looks like that was the issue. will poke admins to install (ahem) "packaging".

from flux-core.

Sorry, this was my bad. I assumed packaging was in the standard library because it is the suggested replacement for distutils.version in PEP 0632. Apparently they thought it was OK because everyone can just pip anyway so what's the big deal.

We should avoid adding this new requesite package and instead find a way to do the simple version compare within the standard library (or just do something by hand)

from flux-core.

Looking around it seems like every fix for deprecated distutils.version pulls in packaging.version, even though it isn't in the standard library. So I guess soon the packaging module will be installed everywhere, but since that isn't the case now, the best solution might be to just copy distutils StrictVersion implementation into am_check_pymod.m4. 🤷

from flux-core.

just a reminder todo to add python3-packaging (or appropriate package name for distro) to the scripts/install scripts.

from flux-core.

I think we're trying to avoid adding a new dependency. However, the best I came up with so far is to try distutils and fall back to packaging if it can't be imported (basically Python == 3.12). I'm guessing in Python 3.12 everyone will need to have packaging installed so this will be a non-issue? (and I'm not sure there's a distro with Python 3.12 yet, so this is all academic!? 😧

from flux-core.

Ah, yeah good point

from flux-core.

fixed by #5459

from flux-core.