Giter VIP home page Giter VIP logo

Comments (10)

garlick avatar garlick commented on September 9, 2024 1

I think we used to always insert the path to Flux's libpmi first in LD_LIBRARY_PATH, but I can't remember why we stopped.

It cause problems on El Cap where Cray's libpmi2.so needs to be found before ours, or else 😿 See #5041

from flux-core.

garlick avatar garlick commented on September 9, 2024 1

I didn't think of that!

So maybe prepend ours in the simple pmi plugin and un-prepend in the cray-pals plugin.

I think that makes sense.

from flux-core.

grondo avatar grondo commented on September 9, 2024 1

plugins are called in the order they were loaded, so builtin plugins always come first currently.

from flux-core.

grondo avatar grondo commented on September 9, 2024

Makes sense to me! I think we used to always insert the path to Flux's libpmi first in LD_LIBRARY_PATH, but I can't remember why we stopped.

Another alternative would be a shell option to specifically do this, e.g. -o force-pmi-path or something. That would be easy to implement in a Lua plugin, with the drawback that we're currently not able to check fo invalid or not consumed shell options, so a typo would go undetected.

from flux-core.

grondo avatar grondo commented on September 9, 2024

Well we could also prepend to LD_LIBRARY_PATH by default again, and add a plugin to flux-coral2 or on the Cray machines that removes it. (e.g. implement the workaround on the one machine that's broken, not the other way around).

I'm just throwing ideas out there though.

from flux-core.

garlick avatar garlick commented on September 9, 2024

I do remember getting yelled at in mattermost for the audacity of modifying LD_LIBRARY_PATH. However, I also think there was extreme irony in that situation. 😃

from flux-core.

garlick avatar garlick commented on September 9, 2024

Hmm if we add to LD_LIBRARY_PATH in the pmi shell plugin and subtract in the flux-coral2 shell plguin, will the ordering work out? Which comes first, built-ins or add-ons?

from flux-core.

garlick avatar garlick commented on September 9, 2024

On second thought, if we only set LD_LIBRARY_PATH when the non-default -o pmi=pmi2 option is specified, then we probably don't need to do anything in cray-pals. All subtracting from LD_LIBRARY_PATH in cray-pals would do is change who wins when both plugins are loaded. Does that even matter?

from flux-core.

grondo avatar grondo commented on September 9, 2024

It guess it would be more convenient for users if we prepended to LD_LIBRARY_PATH by default so MPI works in the common case without the user needing to know if they need to specify -o pmi=pmi2 or why.

I guess this is equivalent to how Slurm works, only they achieve it by installing libpmi into the standard path.

Just a thought.

from flux-core.

garlick avatar garlick commented on September 9, 2024

Well when you put it that way it does make sense.

from flux-core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.