Comments (10)
I think we used to always insert the path to Flux's libpmi first in LD_LIBRARY_PATH, but I can't remember why we stopped.
It cause problems on El Cap where Cray's libpmi2.so needs to be found before ours, or else 😿 See #5041
from flux-core.
I didn't think of that!
So maybe prepend ours in the simple pmi plugin and un-prepend in the cray-pals plugin.
I think that makes sense.
from flux-core.
plugins are called in the order they were loaded, so builtin plugins always come first currently.
from flux-core.
Makes sense to me! I think we used to always insert the path to Flux's libpmi first in LD_LIBRARY_PATH
, but I can't remember why we stopped.
Another alternative would be a shell option to specifically do this, e.g. -o force-pmi-path
or something. That would be easy to implement in a Lua plugin, with the drawback that we're currently not able to check fo invalid or not consumed shell options, so a typo would go undetected.
from flux-core.
Well we could also prepend to LD_LIBRARY_PATH by default again, and add a plugin to flux-coral2 or on the Cray machines that removes it. (e.g. implement the workaround on the one machine that's broken, not the other way around).
I'm just throwing ideas out there though.
from flux-core.
I do remember getting yelled at in mattermost for the audacity of modifying LD_LIBRARY_PATH. However, I also think there was extreme irony in that situation. 😃
from flux-core.
Hmm if we add to LD_LIBRARY_PATH in the pmi shell plugin and subtract in the flux-coral2 shell plguin, will the ordering work out? Which comes first, built-ins or add-ons?
from flux-core.
On second thought, if we only set LD_LIBRARY_PATH when the non-default -o pmi=pmi2
option is specified, then we probably don't need to do anything in cray-pals
. All subtracting from LD_LIBRARY_PATH in cray-pals
would do is change who wins when both plugins are loaded. Does that even matter?
from flux-core.
It guess it would be more convenient for users if we prepended to LD_LIBRARY_PATH by default so MPI works in the common case without the user needing to know if they need to specify -o pmi=pmi2
or why.
I guess this is equivalent to how Slurm works, only they achieve it by installing libpmi into the standard path.
Just a thought.
from flux-core.
Well when you put it that way it does make sense.
from flux-core.
Related Issues (20)
- startlog: need to initialize flag enum to a number HOT 1
- content-sqlite: preallocate database space HOT 26
- some JSON implementations may not be able to handle the full range of job IDs encoded as JSON numbers HOT 2
- shell: increase `output.batch-timeout` default for very large jobs HOT 2
- housekeeping drain message is not informative after timeout HOT 1
- python: need easy way to wait until a subinstance is ready to accept jobs HOT 1
- housekeeping doesn't release resource for a large job HOT 11
- content: flush data if backing store is loaded at a later time HOT 8
- t2406-job-exec-cleanup Racy sub-test HOT 1
- idea: vacuum sqlite on ENOSPC errors during teardown HOT 2
- flux overlay errors does not display version mismatch information
- Suggestion: ability to specify a node range in flux jobs HOT 1
- satisfiability bug: specifying a queue and a constraint matching another queue hangs HOT 1
- throughput.py test: incorrect number of tests submitted in status HOT 10
- job is terminated with `scheduler-restart` exception on Fluxion module reload
- not ok 17 - attach: reports job shell Killed if job shell is killed
- Interested in elastic deployments on Slurm HOT 7
- job-manager: job update feasibility check topic string should be configurable HOT 2
- `flux perilog-run` is not scalable
- job-manager: jobs with alloc-bypass flag appear to still generate a free request to scheduler HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from flux-core.