Comments (4)
It's just for testing. Please leave it as is.
from tofu-controller.
Looking at the chart helpers, it looks like the ultimate default is derived from the chart name:
tf-controller.serviceAccountName
{{- define "tf-controller.serviceAccountName" -}}
...
{{- default (include "tf-controller.fullname" .) .Values.serviceAccount.name }}
...
{{- define "tf-controller.fullname" -}}
{{- if .Values.fullnameOverride }}
{{- .Values.fullnameOverride | trunc 63 | trimSuffix "-" }}
{{- else }}
{{- $name := default .Chart.Name .Values.nameOverride }}
...
It looks to me like, when the rename of the chart happens it should take care of this SA name.
However the runner SA doesn't follow this, instead having a hard coded default value of tf-runner:
{{- define "tf-controller.runner.serviceAccountName" -}}
...
{{- default "tf-runner" .Values.runner.serviceAccount.name }}
...
So, from what I can see, when/if the chart is renamed from tf-controller
to tofu-controller
, it should propagate though to the controller's SA.
The runner SA, current default tf-runner
, won't be affected by the chart rename.
For consitency, should it be tofu-runner
, as opposed to tf-runner
?
from tofu-controller.
@chanwit I'm not sure I follow this issue either, as currently it defaults to tf-runner already if it's left blank.
Is this issue mainly for the testing you did of the coderabbit ai reviewer? Or is it to change the default values.yaml to explicitly state the service account name?
from tofu-controller.
The results from Code Rabbit are not very impressive. We won't adopt this for now.
from tofu-controller.
Related Issues (20)
- Rewrite README for Helm chart
- Unable to see `v0.16.0-rc.3` in releases for tofu HOT 1
- Helm template fails for v0.16.0-rc.4 when you specify imagePullSecrets HOT 4
- Renaming Helm chart to `tofu-controller` HOT 2
- storeReadablePlan Plan read error HOT 2
- Branch planner does plan for all opened PRs in the repo despite on branch HOT 4
- infra.contrib.fluxcd.io/v1alpha2\": Not Implemented" HOT 2
- BranchPlanner cant create terraform resources in kubernetes (RC4) HOT 2
- Feature: Add cross-namespace writeOutputsToSecret for Terraform HOT 1
- tfVarsFiles schema is missing from the Helm chart CRDs HOT 2
- Makefile and pipline should have pinned versions of dependencies HOT 2
- Branch planner does not comment of PR if plan failed due to post plan web hook HOT 1
- Branch Planner Fails due to missing create & delete RBAC for gitrepositories
- Documentation: better documentation on the differences between vars and values.
- Helm chart 0.16.0-rc.4 issue with runner-discovery-service.yaml HOT 2
- Namesapce flux-system is always needed (helm install) HOT 2
- Helm Support for Customizing Tf-Runner HOT 3
- "https://weaveworks.github.io/tf-controller" is not a valid chart repository or cannot be reached HOT 2
- TF-Runner stuck in Terminating state HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tofu-controller.