"Revision" field disambiguation about helm-controller HOT 5 CLOSED

The LastAppliedRevision/LastAttemptedRevision are intended to be common fields for all the toolkit reconcilers, as of now these are used in kustomize and helm controllers. I get your point that from a Chart/Release perspective they are ambiguous.

from helm-controller.

We could record the chart revision as given by Helm in another *ChartRevision status field, question is if this gives us anything of additional value.

from helm-controller.

I see, what about "Source" or "Artifact" rather than "Chart" then:

LastAttemptedSourceRevision
LastSuccessfulSourceRevision

LastAttemptedArtifactRevision
LastSuccessfulArtifactRevision

from helm-controller.

@seaneagan using the same stats fields e,g, LastAppliedRevision/LastAttemptedRevision as a standard across all toolkit controllers allows other controllers/integrations to rely on those for detecting drift. These integrations don't have to depend on our API packages, using the dynamic client-go you could lookup an object.status and check the 2 fields. If we change them in helm-controller, then it will would break the standard. I propose we document these fields in helm-controller docs and explain what they mean in the Helm context.

from helm-controller.

Sure, I guess it's easy enough for an end user to distinguish based on the field values what it likely means as well, it's just something that tripped me up for a second when looking at the field names only, before actually using the tool. Thanks for considering!

from helm-controller.