Giter VIP home page Giter VIP logo

Comments (5)

darsnack avatar darsnack commented on August 26, 2024 1

One option is to build the default functor on ConstructionBase (which will recurse arrays). Then adopt #41 with a Numeric tag that applies to numbers and numeric arrays.

from functors.jl.

CarloLucibello avatar CarloLucibello commented on August 26, 2024 1

https://github.com/chengchingwen/StructWalk.jl allows to define customized walks

from functors.jl.

ToucheSir avatar ToucheSir commented on August 26, 2024

Breaking changes aside, I don't see any major issues with this. Functors.jl is in a weird place because it was designed to be used as part of Flux's module system, yet was written as if it were a generic struct traversal library. The upside is that more libraries outside of FluxML have been able to adopt it, but the downside is confusion from some parts seeming too task-specific (e.g. saying all numeric arrays are leaves) and others seeming too general (how many people know what fmap means?).

from functors.jl.

CarloLucibello avatar CarloLucibello commented on August 26, 2024

Maybe we should allow users to pass their own functor-like function to fmap.
We can also provide a set of functor variations like the aggressive functor proposed here.

from functors.jl.

CarloLucibello avatar CarloLucibello commented on August 26, 2024

I would close this as not planned, since people can just handle numerical arrays or use StructWalk.jl instead.

from functors.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.