Comments (24)
@webbertakken I'd rather make the code a little more robust before actually pushing out a "stable" release, if you don't mind :)
@metya: This is a later added feature "HideOnFocusLost": https://github.com/flyingpie/windows-terminal-quake/#hide-on-focus-lost.
You can turn it off, but I'd figure that it's perhaps the sensible default.
from windows-terminal-quake.
@webbertakken Thank you for looking into this bug :)
@metya Just made a pre release available here: https://github.com/flyingpie/windows-terminal-quake/releases/tag/v0.9
Currently running this version myself, and @webbertakken I'm gonna take a closer look at the code change and the underlying problem soon.
from windows-terminal-quake.
@metya @webbertakken I've tweaked the code as provided by @webbertakken a bit and uploaded a new release. It's basically the same but a little more forgiving regarding the time of sleep.
https://github.com/flyingpie/windows-terminal-quake/releases/tag/v0.9
from windows-terminal-quake.
@webbertakken Thank you, also, the work is still mostly yours, so I'd like to route the PR through you for proper attribution.
@metya F*CK, thanks for the heads-up :)
Let me know when your PC explodes. Send me a message through your microwave.
from windows-terminal-quake.
Closing this issue for now, if anyone encounters the problem again, feel free to smash the subscribe and leave a comment.
from windows-terminal-quake.
Possible duplicate of: #13
Can you see if the linked pr works for you?
And if so could you please describe your system specs?
from windows-terminal-quake.
@metya Should this problem have the same cause as the one @webbertakken is describing, there is a preview with a fix here:
https://github.com/flyingpie/windows-terminal-quake/releases/tag/v0.8
Please let me know if that works for you :)
from windows-terminal-quake.
Sorry, for the late answer!
Yes, apparently it was this bug. Then open the app again when the terminal is already working it fixes the problem.
Now I download the new version 0.8.
And when I'm trying just open it without administrative permission, there is a windows notification about that some error and nothing happens, only the normal terminal opens. But if I start it again with administrative permission with an opened terminal it starts normally. If I don't do administrative permission in a second launch I get another error.
Sorry for the Russian.
The first notification says the sequence contains no elements
or something like that. I don't know what it was originally, before localization.
The second error says Access Decline
So I need to launch with administrative permission in version 0.8
With 0.7 it is not needed.
from windows-terminal-quake.
Also, I notice that now terminal disappears without focus. And you need to cntl+` again every time. I think earlier there wasn't that behavior.
from windows-terminal-quake.
I downloaded 0.8 today and see a "the sequence contains no elements" on launch. Terminal seems to launch fine, but It seems this utility crashes after it launches the terminal. I don't see any other error messages and get the same results whether or not I use administrative mode. I only started using 0.8 because the earlier version of this utility I was using stopped working(not sure which version offhand tbh). I am inclined to think that Microsoft changed something. I have Windows Terminal
'Version: 1.2.2381.0' and Windows 10 pro 'Version 10.0.19041 Build 19041'
Edit: If I leave the terminal open and re-run the utility it seems to work.
from windows-terminal-quake.
I'm now having this same error also.
the sequence contains no elements
I can confirm that the same version worked before. I received some update from windows in between I believe but did not update the terminal or the quake launcher.
Windows terminal 1.2.2381.0
Windows 10 Pro - version 1909 build 18363.1016
from windows-terminal-quake.
Version 0.7 works well, but you need to launch it twice. Minor problem to me, but without errors, though 😄
from windows-terminal-quake.
Possibly related
1.3 ONLY: We've disabled the creation of a new process environment block due to a regression in Windows PowerShell
(x86); see #7418 for further details
source: microsoft/terminal/releases/v1.3.2651.0
from windows-terminal-quake.
Fixed in #25 for me. Seems like the program is simply too eager.
Tested with latest version of Terminal: 1.3.2651.0
from windows-terminal-quake.
Well, waiting for the merge and new build.
from windows-terminal-quake.
@metya could you have a look if this version works for you too?
from windows-terminal-quake.
sorry for the long answer.
yes, it totally works for me.
seems now version 0.9 already fine
from windows-terminal-quake.
@metya Thank you for the confirmation!
@webbertakken I'd like to change the sleep to a retry-construct, since now there's a chance the process isn't ready yet. With a retry such as the one I used for window opacity here: https://github.com/flyingpie/windows-terminal-quake/blob/master/windows-terminal-quake/Native/TransparentWindow.cs, we're no longer dependent on the process being ready after X milliseconds, and we don't have to wait at all if it works on the first try.
What are you thoughts?
from windows-terminal-quake.
@flyingpie I guess that could work.
Could you please merge the current working version before you do and create 0.9 release?
That way we could work incrementally and check if something breaks every step of the way.
from windows-terminal-quake.
Hm.
After rebooting my computer behaviour of the app became as erlier sometimes.
I mean, sometimes when I click the app it launch terminal only, but sometime it works as normal, launch the terminal and the quake mode. Maybe time of sleep not enough or something like that.
from windows-terminal-quake.
And I have another question. When the terminal out of focus it disappears from the screen and I have to push ctrl + ` to get the terminal back. It is normal behavior or not?
from windows-terminal-quake.
It seems that finally I can join the club of people with weird process issues. Perhaps updates to either Windows or Windows Terminal.
Anyway, I've been messing around some more and updated the v0.9 release, and I haven't encountered any problems so far. Note that I had all sorts of issues like the process not being picked up at all by windows-terminal-quake, or not being able to toggle anything.
Link for the lazy:
https://github.com/flyingpie/windows-terminal-quake/releases/tag/v0.9
from windows-terminal-quake.
I'll have a look soon.
from windows-terminal-quake.
thank you for update!
I tried a new release and at first look, it just works fine :)
But in release's zip name you named it with v0.8. Just noted :)
from windows-terminal-quake.
Related Issues (20)
- Horizontal coverage does not allow decimals HOT 3
- Unexpected behaviour: Terminal content scrolls up when console is hidden. Input position stays. HOT 4
- Suggestion: Use JSON5 for configuration file. HOT 15
- Unexpected behaviour: Hiding console after maximizing window reverts back to old size.
- Error opening terminal HOT 6
- Package/Release on winget HOT 7
- Toggling always switches back to the original virtual desktop (v1.2.0+) HOT 1
- Support multiple modifiers HOT 5
- Fix scoop installation on Quake Documentation HOT 1
- MSTerminal: snapToGridOnResize= false. Incompatible with windows-terminal-quake HOT 9
- Running it with administrative permission HOT 3
- Can you do the quake behavior for multiple apps? HOT 25
- Hiding quake terminal creates new tray icon every time HOT 13
- Taskbar icon cannot be hidden HOT 12
- Sometimes it isn't openned at full screen and shows the taskbar HOT 2
- float values no longer accepted for *ScreenCoverage HOT 3
- Weird input focus behavior on v1.2.0 HOT 4
- Main window handle not accessible HOT 3
- Drop down when a new instance of Windows Terminal is launched HOT 1
- screen cleaned when losing then getting back focus HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from windows-terminal-quake.