ignore pragma doesn't work on nested maps about nimyaml HOT 1 CLOSED

Certainly not intentional, this is an error.

Error is here:

This portion of the macro creates the branch that is executed when a field name is not mappable. The generated AST looks like this:

when failOnError:
  raise constructionError(…)

when ignore has been set and is empty, this branch is reached with failOnError being false, so… nothing happens. This is bad.

Compare what happens when there are explicitly ignored field names and a field is encountered with one of those names:

The fix would be:

• extract the code skipping over the value to an own function
• generate an else branch for the when statement above and call this function

My Nim is a bit rusty so if you want to tackle this a PR would be very welcome :)

from nimyaml.