Comments (5)
Thanks for reporting this @irnc.
What I believe is happening is that VS Code in 1.83.0 is adding a definition to the wikilink (you can see that by putting the cursor is on a wikilink and then running the Go to definition
command, using the F12
key).
- Before (and now when there is no wikilink definition section) the only definition was the one added by Foam.
- Now VS Code adds as definition the one of the link at the bottom of the file.
I am not sure why they decided to do so.
One might say it's correct, as the wikilink is "defined" in that line. On the other hand when you Go to definition
on a type in a typescript file, you don't got to the import
statement, but to the resource that defines the type. So if anything I would have expected VS Code to navigate to the file associated to the wikilink definition.
I don't know if there is much that can be done on Foam's side. Maybe there is a way to increase the priority of our definition (cmd+click
navigates to the first definition).
This needs a bit of research. Might also be worth raising an issue on the VS Code project.
from foam.
- Is there any configuration or workaround for this issue? @riccardoferretti @irnc
from foam.
I don't know of any configuration that would bring previous behaviour back. As Riccardo said, this needs a bit of research to investigate and resolve the issue.
For me workaround was in switching off wikilink references generation, as notes editing workflow doesn't need them. Rationale behind this decision was simple: because it is a concern of a publishing phase, it should be addressed at a later stage.
from foam.
Related Issues (20)
- Markdown in code HOT 1
- Sort order of notes in Tag/Note Explorer by modification time HOT 2
- Discord invitation link is invalid HOT 2
- Tag Explorer - Show tags in current file HOT 1
- When using workspaces, wikilink are not working HOT 12
- When including note with links to non-existent files, getting "cyclic link detected" warning HOT 6
- Wikilinks Not Displayed Correctly In Tables With VS Code 1.82.0 HOT 1
- Feature request - add Admonitions/Callouts HOT 2
- Release API v1
- Improve tag search HOT 1
- Wikilinks activated: special characters make the links to not work HOT 6
- foam-template bot sync not replicating .vscode directory HOT 3
- Ambiguous identifier when notes share the same file name with different capitalisation HOT 1
- [Proposal] Folders for tags HOT 2
- Bidirectional links as code comments in non-markdown files? HOT 1
- Disable Journal Title HOT 3
- Allow completion for title in create note from template HOT 3
- Can foam link title change?
- Add a date variable for templates in ISO 8601 format HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from foam.