Giter VIP home page Giter VIP logo

Comments (5)

riccardoferretti avatar riccardoferretti commented on June 10, 2024

Thanks for reporting this @irnc.

What I believe is happening is that VS Code in 1.83.0 is adding a definition to the wikilink (you can see that by putting the cursor is on a wikilink and then running the Go to definition command, using the F12 key).

  • Before (and now when there is no wikilink definition section) the only definition was the one added by Foam.
  • Now VS Code adds as definition the one of the link at the bottom of the file.

I am not sure why they decided to do so.
One might say it's correct, as the wikilink is "defined" in that line. On the other hand when you Go to definition on a type in a typescript file, you don't got to the import statement, but to the resource that defines the type. So if anything I would have expected VS Code to navigate to the file associated to the wikilink definition.

I don't know if there is much that can be done on Foam's side. Maybe there is a way to increase the priority of our definition (cmd+click navigates to the first definition).
This needs a bit of research. Might also be worth raising an issue on the VS Code project.

from foam.

t2hv33 avatar t2hv33 commented on June 10, 2024

from foam.

irnc avatar irnc commented on June 10, 2024

I don't know of any configuration that would bring previous behaviour back. As Riccardo said, this needs a bit of research to investigate and resolve the issue.

For me workaround was in switching off wikilink references generation, as notes editing workflow doesn't need them. Rationale behind this decision was simple: because it is a concern of a publishing phase, it should be addressed at a later stage.

from foam.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.