Giter VIP home page Giter VIP logo

Comments (13)

riccardoferretti avatar riccardoferretti commented on June 2, 2024 4

Ok, I think I have found the actual problem and pushed 0.25.11 which should have addressed it.
@ais @ktrNozomi can you please let me know if things get better?

from foam.

ktrNozomi avatar ktrNozomi commented on June 2, 2024 1

Ok, I think I have found the actual problem and pushed 0.25.11 which should have addressed it. @ais @ktrNozomi can you please let me know if things get better?

Thanks a lot for your work! Now everything works fine on my machine. Thanks @ais too for finding bugs!

from foam.

ais avatar ais commented on June 2, 2024

It takes 2 – 5 seconds to save a file after #1344. I assume this is why input is blocked when the Vim extension is enabled.

See also: #1344 (comment)

from foam.

riccardoferretti avatar riccardoferretti commented on June 2, 2024

Thanks for reporting the issue, I will push the fix right away (silly bug)

from foam.

riccardoferretti avatar riccardoferretti commented on June 2, 2024

I just pushed v0.25.10 - let me know if you are still experiencing the problem. Will close the issue if the problem is gone

from foam.

ais avatar ais commented on June 2, 2024

v0.25.10 seems to have made it worse for me. My inputs are blocked on saving now even when I am not using the Vim extension, even tho the file seems to save immediately now. Code is using 30% CPU during this time; thrice as much as patch 9.

from foam.

riccardoferretti avatar riccardoferretti commented on June 2, 2024

Can you check what happens if you revert to 0.25.8 ? Does that solve the issues you are having?

from foam.

ktrNozomi avatar ktrNozomi commented on June 2, 2024

@riccardoferretti after updating to v0.25.10, the key stroke responds normally; but I see as @ais said, the same situation happens to me -- the CPU increased to 30% after saving the file. But this doesn't influence the fluency on my machine, my CPU is AMD R7 5850U.

from foam.

riccardoferretti avatar riccardoferretti commented on June 2, 2024

@ktrNozomi can you also do the comparison with 0.25.8? Just wanna be sure that in the meantime something hasn't changed in VS Code that instead seems related to the extension (this happened in the past).
Can you and @ais please:

  1. check the current state with 0.25.10
  2. revert the extension to 0.25.8
  3. compare the resource utilization
  4. let us know :)

I am saying this because, beside the bug I introduced, the changes should not have performance implications. There might be another more subtle bug, looking into it

from foam.

ktrNozomi avatar ktrNozomi commented on June 2, 2024

@riccardoferretti after testing, it seems that v0.25.8 has no problem and v0.25.10 has performance issue.

This is v0.25.8:
v0 25 8

This is v0.25.10:
v0 25 10

from foam.

ais avatar ais commented on June 2, 2024

I reverted to 0.25.8 shortly after my last comment as an immediate solution, and haven't experienced any issues with it. CPU usage never goes above 3%.

I haven't updated Code recently; I'm running v1.85.2 (2024-01-18).

from foam.

riccardoferretti avatar riccardoferretti commented on June 2, 2024

Ok thx, will look into it

from foam.

riccardoferretti avatar riccardoferretti commented on June 2, 2024

Thank you both for bringing it up to my attention, cheers!

from foam.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.