Comments (9)
I added a section in the readme on the branch. Is that sufficient?
You're sound man 👍
from jollyday.
I thought about this. I think we need to do two things.
- Rename the 'official holiday' to 'public holiday', because this is what it is. see #482
- Add bank holiday and provide the bank holidays for the specific countries. see #467
@XSpielinbox any thoughts about this?
from jollyday.
@derTobsch Thank's for the explanation.
Sounds good.
Just a side note: From understand the Scottish Government websites, the current holidays are actual public holiday in that sense, that not only banks are closed, as indicated by the linked officeholidays.com website, but this can then be discussed in a separate issue, if necessary.
from jollyday.
Could you describe the proposed changes meanings, please.
Does the "School Holidays" represent when schools are closed?
What's the purpose of "Authorities"?
from jollyday.
Could you describe the proposed changes meanings, please. Does the "School Holidays" represent when schools are closed? What's the purpose of "Authorities"?
I added a section in the readme on the branch. Is that sufficient?
from jollyday.
I added a section in the readme on the branch. Is that sufficient?
You're sound man 👍
Did you took a look?
The following holiday types are supported:
| Type | Description |
|-------------|----------------------------------------------------------------------------------------------------------------------|
| Official | Official public holiday |
| Bank | Bank holiday, banks and offices are closed |
| School | School holiday, schools are closed |
| Authorities | Authorities are closed |
| Unofficial | Unofficial holiday that is no <br/>Bank, School or Authorities holiday <br/>(Deprecated, please use the other types) |
I think I will enhance this table with a column of official yes/no
from jollyday.
Just thinking, it might be very tricky with schools, as various types may have different timings, e.g. creche (kindergarten), primary, secondary, universities, etc... They all might have their own timings. For instance in Ireland all those types have different patterns. In Poland it goes by regions.
from jollyday.
Just thinking, it might be very tricky with schools, as various types may have different timings, e.g. creche (kindergarten), primary, secondary, universities, etc... They all might have their own timings. For instance in Ireland all those types have different patterns. In Poland it goes by regions.
Good objection, I think it would be enough for the start to only add Bank
holidays additionally to Official
and Unofficial
from jollyday.
I thought about this. I think we need to do two things.
* Rename the 'official holiday' to 'public holiday', because this is what it is. see [Rename 'Official Holiday' to 'Public Holiday' #482](https://github.com/focus-shift/jollyday/issues/482) * Add bank holiday and provide the bank holidays for the specific countries. see [Add new holiday type bank and rename official holiday to public holiday #467](https://github.com/focus-shift/jollyday/pull/467)
@XSpielinbox any thoughts about this?
Do you have a definition of "official holiday", "public holiday" and "bank holiday" you are following here?
If so, this should be written down in an ADR.
Because, as far as I can tell the meaning of these words might slightly differ from country to country / source to source.
Is is documented in the readme on the branch.
The following holiday types are supported:
Type Description Public Public holiday Bank Bank holiday, banks and offices are closed
I know that there are different definitions, especially in Scotland, England, ...., but I followed https://www.officeholidays.com/about/definitions and https://en.wikipedia.org/wiki/Public_holiday e.g. In these cases I would say, that a public holiday is "...generally established by law and is usually a non-working day during the year".
A bank holiday is a day where the bank and offices are closed and is not a public holiday.
So with these definitions there are mostly public holidays in this library and some bank holidays e.g. in Scotland. But the bank holidays in England are only named "bank holidays" but are normal public holidays.
from jollyday.
Related Issues (20)
- Restoration Day missing in Geneva HOT 1
- Commémoration du Plébiscite missing in Jura HOT 1
- Queen Elizabeth II Memorial Day is missing for New Zealand
- Fix missing holiday description translations
- Error: Cannot instantiate datasource instance because there is no implementations HOT 6
- Improve tests and javadoc for ManagerParameters
- Fix broken sonarcoud coverage report
- Jackson mapping partially incorrect
- Describe Development Decisions in the Readme
- New York Stock Exchange calendar missing Juneteenth holiday
- Warning module not found HOT 4
- PR: Use only POJOs for Jollyday configuratoin to have zero dependencies on Jackson/JAXB or any other xml parsing libraries
- Typo in NYSE-EURONEXT and missing in HolidayCalendar enum
- St Brigid’s Day is wrong when 1st of February is a Friday
- Caching "getHolidays"
- Filter on "getHolidays" via "HolidayType"
- Åland Islands Whit Sunday is missing
- Whit Sunday missing in Liechtenstein
- Rename 'Official Holiday' to 'Public Holiday'
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jollyday.