Tests about croppie HOT 6 OPEN

I can't find the unit tests either.

from croppie.

Unit test foundation proposal in PR : #84

from croppie.

Since #84 was merged, can this be closed then?

from croppie.

@JoeDuncko Not really ... the PR that was merged in just lays the foundation. I'd like more things to actually be tested. Like the result of a crop, the boundary checks, etc. I don't really know where to start with these. I haven't had the time to dive into how things like Croppie can be tested.

from croppie.

@thedustinsmith that makes sense. Can we make this issue more specific so that we can qualify what a PR that would close this issue would look like? Or make a new issue that does that? Even if it's just a research task, I think it'd make this more actionable for contributors..

from croppie.

That sounds great. However, I don't really have the time to focus on croppie right now.

I can sum up a list of common troubles we have encountered as far as github issues are concerned. If you're interested in helping, feel free to transfer these into manageable lists/issues separated however you feel appropriate.

• Make sure we're exporting correctly across all module definitions: #532
• Resulting image is correct dimensions & not distorted
• binding with points
• enforcing boundary doesn't let the image escape the boundary
• rotating with enforceBoundary true maintains boundary restriction
• cropping with enforceBoundary false results in expected image
• image that is smaller than boundary reacts accordingly depending on enforceBoundary true/false

Sorry I can't be more specific at the moment. I'd love help on the project. I don't have the time to work on this like I used to.

from croppie.