Comments (5)
Now possible with https://docs.rs/rust-releases/0.6.1/rust_releases/search/struct.Bisect.html
from cargo-msrv.
implemented by #64
from cargo-msrv.
is there a reason this isn't the default?
from cargo-msrv.
Hi @danieleades, thanks for your question.
I think there are two reasons at the moment why it isn't the default:
- The bisect implementation has not been battle tested and aside from my own use, I've received no feedback on how well the implementation performs. On the flip side, having it as the default may very well generate such feedback.
- At the time of implementation there were some issues regarding different versions of
Cargo.lock
files. Older Cargo versions did not support newer lock files. When using bisection, this issue become much more prominent, as we would now install much older toolchains, while currently, most often the MSRV is a much more recent version of Rust which have support for the newer lock file. This issue can be alleviated by runningcargo msrv
with the--ignore-lockfile
flag, but it also changes the behaviour since we now run a toolchain against unfrozen dependency versions.
However, a binary search can significantly reduce the time necessary to determine the MSRV, especially when you also reduce the search space further by setting --minimum <version>
(e.g. 1.31.0
for Rust edition 2018), so it's definitely a worth to think about, and to start a conversation about.
What would be the primary reason(s) for you to have --bisect
as the default?
from cargo-msrv.
I've moved this conversion to #97
from cargo-msrv.
Related Issues (20)
- Document output format: json
- Feature request: Cleanup toolchains installed for MSRV search HOT 1
- Make an event scope an inherent part of an event
- Add a shared id to a chain of check commands
- Create a separate human output handler per subcommand or shared output type
- Unable to spawn process '"show"' HOT 4
- Mention rustup is required to perform an MSRV search
- Investigate: which dependencies are duplicate or unnecessary HOT 2
- Remove left-over `eprintln!`
- Be consistent with "Is Incompatible" and "Is compatible" uppercase formatting
- Update storyteller dependency to 0.8.0
- Update Clap to v4
- Docker images HOT 1
- Tweak release profile settings HOT 1
- Add find subcommand and deprecate top-level find
- Add support for automatic lockfile conversions
- book: document 'human' output format
- Add support for writing the MSRV to the clippy config
- cargo msrv set: warn if Rust version is unknown
- Re-enable "write msrv on find' test case
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cargo-msrv.