Comments (2)
foresterre
commented on June 25, 2024
1
Update: A friend pointed out to me that in 1.70 (~4 days from now), the sparse protocol will be enabled by default. This means that once I have 1.70 as my default toolchain, I can remove the lines in config.toml, which causes this issue to be a non-issue.
In that case I'll wait for 1.70 to be released; and will assess whether support should be added separately after the release.
Regardless, thanks for the report!
from cargo-msrv.
luukvanderduim
commented on June 25, 2024
With cargo-msrv 0.15.1 I see "invalid" MSRV.
(Not sure if the advice is really invalid, it concerns a hiatus in a few versions)
When running in the workspace of atspi 0.18
Check for toolchain '1.67.1-x86_64-unknown-linux-gnu' failed with:
┌──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐
│ error: failed to get `enumflags2` as a dependency of package `atspi-common v0.2.0 (/atspi/atspi-common)` │
│ │
│ Caused by: │
│ failed to load source for dependency `enumflags2` │
│ │
│ Caused by: │
│ Unable to update registry `crates-io` │
│ │
│ Caused by: │
│ usage of sparse registries requires `-Z sparse-registry` │
└──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘
Check for toolchain '1.69.0-x86_64-unknown-linux-gnu' succeeded
Check for toolchain '1.68.2-x86_64-unknown-linux-gnu' succeeded
Finished The MSRV is: 1.68.2 When cargo +1.65.0-x86_64-unknown-linux-gnu check is run manually however, this succeeds.
Finished dev [unoptimized + debuginfo] target(s) in 0.16sHowever:
cargo +1.66.0-x86_64-unknown-linux-gnu check fails:
error: failed to get `enumflags2` as a dependency of package `atspi-common v0.2.0 (/home/luuk/code/atspi-various-doc/atspi/atspi-common)`
Caused by:
failed to load source for dependency `enumflags2`
Caused by:
Unable to update registry `crates-io`
Caused by:
usage of sparse registries requires `-Z sparse-registry`Versions prior to 1.65 are known to not compile atspi because it uses let - else constructions,
build summaries:
1.65.0 fine
1.66.0 sparse registry requires -Z sparse-registry,
1.67.1 sparse registry requires -Z sparse-registry,
1.68.2 fine
1.69.0 fine
1.70.0 fine
1.71.0 fine
Note that it does not matter if the dev-dependency of enumflags2 is inherited from the workspace or explicitly versioned in-place.
I think the advice on MSRV is sound, however the hiatus is odd and it may be valuable to others to know.
Also, it might be possible I am doing something wrong, in which case I'd be happy to learn.
from cargo-msrv.
Related Issues (20)
- indicatif 0.17.4 breaks rendering HOT 1
- feature: cargo-msrv rules (msrv by offset)
- feature: cargo-msrv suggest
- Cargo resolves different versions of dependencies (with different MSRV) from Cargo 1.60 and up HOT 14
- failure in GitLab runner: error: unexpected argument 'sh' found HOT 4
- verification does not respect workspace members with a virtual workspace HOT 4
- The code is hard to read/follow HOT 1
- Split expected and unexpected errors
- Failure on Github Actions HOT 2
- Custom check? HOT 4
- Docker image fails with GLIBC not found error HOT 2
- Use compilation target instead of build machine target for MSRV checks
- v0.16.0-beta.16 release builds failed: third party license files failed to generate HOT 1
- Add `--features` parameter
- Posible to install clippy for using it as a check? HOT 4
- Add `--workspace` flag to subcommand `find`
- Run tests which write to disk in temp dirs
- Coverage is broken due to aHash or crc32c <0.7.0 used in transitive dependency
- check if job result is a clippy false positive
- Add `--strict` flag to cargo msrv verify
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cargo-msrv.