Giter VIP home page Giter VIP logo

Comments (3)

gbvanrenswoude avatar gbvanrenswoude commented on June 17, 2024

The presence of the yarn.lock file also makes several Container Scanning tools go off.

from form-data.

jaikanthjay46 avatar jaikanthjay46 commented on June 17, 2024

Yes. That is one more reason

from form-data.

tukusejssirs avatar tukusejssirs commented on June 17, 2024

I also noticed README.md.bak, but I don’t have yarn.lock. Maybe because I don’t use yarn. 🤷‍♂️

I have found the reason why README.md.bak is there: in package.json (L27-30), there are the following scripts:

"update-readme": "sed -i.bak 's/\\/master\\.svg/\\/v'$(npm --silent run get-version)'.svg/g' README.md",
"restore-readme": "mv README.md.bak README.md",
"prepublish": "in-publish && npm run update-readme || not-in-publish",
"postpublish": "npm run restore-readme"

Basically, when someone runs npm run publish, it backs up README.md (actually, there is no such file, as the file is name Readme.md; maybe the maintainer runs this on MS Windows) and updates the SVG path. After publishing, for some reason it restores the original (backed up) README.md.

So, all we need to do to fix this issue is:

  1. either rename Readme.md to README.md or update update-readme and restore-readme scripts to use Readme.md and Readme.md.bak filenames;
  2. add files array to package.json:
{
  ...
  files: [
    "index.d.ts",
    "lib",
    "Licence",
    "package.json",
    "Readme.md"  // Or `README.md`
  ]
  ...
}

If @niftylettuce (or any other maintainer) is okay with this, I can create a PR. 😉

from form-data.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.