Bug: unused imports in icon-types.ts in kit (urgent/critical) about font-awesome HOT 16 CLOSED

for the sake of my mind (or someone else's mind 😀), just apply a patch to your KIT after npm install:

--- node_modules/@awesome.me/kit-XXX/icons/modules/icon-types.ts.orig	2024-05-01 08:07:09
+++ node_modules/@awesome.me/kit-XXX/icons/modules/icon-types.ts	2024-05-01 08:07:17
@@ -1,5 +1,5 @@
 import type { IconDefinition, IconPack } from '@fortawesome/fontawesome-common-types';
-import type { Icon, IconParams } from '@fortawesome/fontawesome-svg-core'
+// import type { Icon, IconParams } from '@fortawesome/fontawesome-svg-core'
 
 export type IconPrefix = 'fast'|'fass'|'fasr'|'fasl'|'fakd'|'fak'|'fad'|'fat'|'fas'|'far'|'fal'|'fab';
 

I know this is really ugly and a workaround, but at least it lets me build my final application

from font-awesome.

We've got our fix done finally and merged in. We're testing it through all the use cases (including some here) that everyone has found to make sure we've got them fixed.

So. We're testing. Feeling pretty good at the moment.

from font-awesome.

Alright everyone! We've got this released and it's available for testing.

You'll need to go into your Kit and make some kind of change that kicks off a package build and publishing. You can add and then remove an icon, or add then remove a style. Both of those should do it.

Let me know what you find, if it fixes things for you, or if there are more questions.

Sorry this one took so long. We learned a LOT about .tsconfig files during this.

from font-awesome.

3 months after reporting and it's still an issue in Vite + TS + React + Kits.

from font-awesome.

@lctech-LeoLioa No update yet. We've ran into a tricky little issue that's going to need more testing. It's still on our radar.

@stream-jdibling it's pretty tricky

from font-awesome.

Same issue here, any ETA on a fix? Cheers

from font-awesome.

for the sake of my mind (or someone else's mind 😀), just apply a patch to your KIT after npm install:

--- node_modules/@awesome.me/kit-XXX/icons/modules/icon-types.ts.orig	2024-05-01 08:07:09
+++ node_modules/@awesome.me/kit-XXX/icons/modules/icon-types.ts	2024-05-01 08:07:17
@@ -1,5 +1,5 @@
 import type { IconDefinition, IconPack } from '@fortawesome/fontawesome-common-types';
-import type { Icon, IconParams } from '@fortawesome/fontawesome-svg-core'
+// import type { Icon, IconParams } from '@fortawesome/fontawesome-svg-core'
 
 export type IconPrefix = 'fast'|'fass'|'fasr'|'fasl'|'fakd'|'fak'|'fad'|'fat'|'fas'|'far'|'fal'|'fab';
 

I know this is really ugly and a workaround, but at least it lets me build my final application

You can fix this error by changing/adding this line to your tsconfig file:

"noUnusedLocals": false,

from font-awesome.

Quick update. We're still working on this. We want to make sure it's actually fixed before we release and TypeScript can be tricky.

from font-awesome.

I fell into this issues recently: it is a real blocker. Hope this will be fixed soon
I am using classic command "tsc && vite build"

from font-awesome.

Quick update. We're still working on this. We want to make sure it's actually fixed before we release and TypeScript can be tricky.

any update about this issue ?

from font-awesome.

my dudes, lets go please. no way it's THAT hard

from font-awesome.

Another quick update. Testing looked great (all the issues we've collected look like they are now resolved.) We'll most likely be deploying this week.

from font-awesome.

not to mention that kits are not free...

from font-awesome.

You can fix this error by changing/adding this line to your tsconfig file:

"noUnusedLocals": false,

@nathandaly yep that was an option.

However, I don't want to loosen the constraints and allow unused imports or unused variables.

from font-awesome.

Can we get an ETA on this fix?

from font-awesome.

Checking back in on this!

from font-awesome.