Comments (1)
titanism
commented on June 14, 2024
Your code at https://gist.github.com/sumitpatel93/4560cb3760e99e0f2a63497dc51d04bf is mixing usage of async/await with callbacks, which is not supported and is bad code practice (it's an anti-pattern). It looks like we need to update our example on our side to support better code practice.
Also, you have a bug in your code at https://gist.github.com/sumitpatel93/4560cb3760e99e0f2a63497dc51d04bf#file-sendemail-js-L27-L31. You can see that you do not resolve for the case when there is !template found.
from email-templates.
Related Issues (20)
- Double quote on subject HOT 1
- Is there any date/number/currency formatting tools with i18n? HOT 1
- [fix] Syntax error when imported HOT 2
- [fix] Unable to use plugin HOT 2
- [fix] Pug block extends doesn't work HOT 1
- [fix] i18n - auto translate HOT 1
- [feat] extract locale phrases AOT HOT 3
- [fix] The juice step does not seem to be working HOT 1
- [feat] - AWS s3 as a source for template files HOT 2
- Critical and high severity vulnerabilities HOT 1
- [fix] CC emails not working if we specify mutiple emails instead of single HOT 6
- [fix] CC emails not working if we specify mutiple emails instead of single email HOT 2
- [fix] Move preview-email to devDeps
- [fix] DESCRIPTIVE TITLE HOT 1
- [fix] Peer dependency needs a bump @loadjs/consolidate HOT 1
- Getting monorepo-symlink-test Security Vulnerability warning due to resolve package of email-templates
- [fix] issue with eta.js HOT 5
- [DEP0174] DeprecationWarning: Calling promisify on a function that returns a Promise is likely a mistake. HOT 2
- Getting error for Node FS in consolidate package dependancy.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from email-templates.