Giter VIP home page Giter VIP logo

Comments (12)

jpelton-stroud avatar jpelton-stroud commented on May 30, 2024 1

apologies; added the following to initial report.

    "webpack": "^5.65.0",
    "webpack-cli": "^4.9.1",
    "gas-webpack-plugin": "^2.1.0",

from gas-webpack-plugin.

jpelton-stroud avatar jpelton-stroud commented on May 30, 2024 1

@fossamagna rec'd change to autoGlobalExportsFiles appears to have resolved the immediate issue, but now I'm running into Terser errors. Will post an example repo asap.

from gas-webpack-plugin.

jpelton-stroud avatar jpelton-stroud commented on May 30, 2024 1

@fossamagna sorry for the long wait; your help is much appreciated.

example repo

as previously stated, after making the recommended change, I'm now running into a TERSER error in the output file:

ERROR in dist/Code.js
dist/Code.js from Terser plugin
Unexpected token name «global», expected punc «,» [dist/Code.js:79,23]
    at js_error (C:\Users\v611558\Projects\gas-webpack-plugin-example\node_modules\terser\dist\bundle.min.js:550:11)
    at croak (C:\Users\v611558\Projects\gas-webpack-plugin-example\node_modules\terser\dist\bundle.min.js:1274:9)
    at token_error (C:\Users\v611558\Projects\gas-webpack-plugin-example\node_modules\terser\dist\bundle.min.js:1282:9)
    at expect_token (C:\Users\v611558\Projects\gas-webpack-plugin-example\node_modules\terser\dist\bundle.min.js:1295:9)
    at expect (C:\Users\v611558\Projects\gas-webpack-plugin-example\node_modules\terser\dist\bundle.min.js:1298:36)
    at call_args (C:\Users\v611558\Projects\gas-webpack-plugin-example\node_modules\terser\dist\bundle.min.js:3289:17)
    at subscripts (C:\Users\v611558\Projects\gas-webpack-plugin-example\node_modules\terser\dist\bundle.min.js:3200:30)
    at expr_atom (C:\Users\v611558\Projects\gas-webpack-plugin-example\node_modules\terser\dist\bundle.min.js:2523:20)
    at maybe_unary (C:\Users\v611558\Projects\gas-webpack-plugin-example\node_modules\terser\dist\bundle.min.js:3310:19)
    at expr_ops (C:\Users\v611558\Projects\gas-webpack-plugin-example\node_modules\terser\dist\bundle.min.js:3361:24)

webpack 5.65.0 compiled with 1 error in 1965 ms
The terminal process "C:\WINDOWS\System32\WindowsPowerShell\v1.0\powershell.exe -Command npm run build" terminated with exit code: 1.

I will add that changing the import statement to import { doGet } from './app/do-get'; does compile without issue, but then we're back to the original error. Any thoughts/pointers would be appreciated.

from gas-webpack-plugin.

jpelton-stroud avatar jpelton-stroud commented on May 30, 2024 1

thank you for your assistance, @fossamagna; all is working as intended after implementing your suggestions.

from gas-webpack-plugin.

fossamagna avatar fossamagna commented on May 30, 2024

@jpelton-stroud Hi, tell me the version of webpack and gas-webpack-plugin you are using.

from gas-webpack-plugin.

fossamagna avatar fossamagna commented on May 30, 2024

@jpelton-stroud Can i see your tsconfig.json?

from gas-webpack-plugin.

jpelton-stroud avatar jpelton-stroud commented on May 30, 2024

I've tried a couple, actually; if you have a preferred or known good config, i'm flexible (just figuring things out, atm, no production work):

clasp recommended

{
  "compilerOptions": {
    "lib": ["esnext"],
    "experimentalDecorators": true
  }
}

ts2gas recommended

{
  compilerOptions: {
    experimentalDecorators: true,
    isolatedModules: true,
    module: "None",
    noImplicitUseStrict: true,
    noLib: true,
    noResolve: true,
    target: "ES3",
  },
  // the following property is to document this little known feature
  // renamedDependencies: { SomeName: 'SomeOtherName' },
}

default tsc init

{
  "compilerOptions": {
    /* Visit https://aka.ms/tsconfig.json to read more about this file */

    /* Projects */
    // "incremental": true,                              /* Enable incremental compilation */
    // "composite": true,                                /* Enable constraints that allow a TypeScript project to be used with project references. */
    // "tsBuildInfoFile": "./",                          /* Specify the folder for .tsbuildinfo incremental compilation files. */
    // "disableSourceOfProjectReferenceRedirect": true,  /* Disable preferring source files instead of declaration files when referencing composite projects */
    // "disableSolutionSearching": true,                 /* Opt a project out of multi-project reference checking when editing. */
    // "disableReferencedProjectLoad": true,             /* Reduce the number of projects loaded automatically by TypeScript. */

    /* Language and Environment */
    "target": "es2016",                                  /* Set the JavaScript language version for emitted JavaScript and include compatible library declarations. */
    // "lib": [],                                        /* Specify a set of bundled library declaration files that describe the target runtime environment. */
    // "jsx": "preserve",                                /* Specify what JSX code is generated. */
    // "experimentalDecorators": true,                   /* Enable experimental support for TC39 stage 2 draft decorators. */
    // "emitDecoratorMetadata": true,                    /* Emit design-type metadata for decorated declarations in source files. */
    // "jsxFactory": "",                                 /* Specify the JSX factory function used when targeting React JSX emit, e.g. 'React.createElement' or 'h' */
    // "jsxFragmentFactory": "",                         /* Specify the JSX Fragment reference used for fragments when targeting React JSX emit e.g. 'React.Fragment' or 'Fragment'. */
    // "jsxImportSource": "",                            /* Specify module specifier used to import the JSX factory functions when using `jsx: react-jsx*`.` */
    // "reactNamespace": "",                             /* Specify the object invoked for `createElement`. This only applies when targeting `react` JSX emit. */
    // "noLib": true,                                    /* Disable including any library files, including the default lib.d.ts. */
    // "useDefineForClassFields": true,                  /* Emit ECMAScript-standard-compliant class fields. */

    /* Modules */
    "module": "commonjs",                                /* Specify what module code is generated. */
    // "rootDir": "./",                                  /* Specify the root folder within your source files. */
    // "moduleResolution": "node",                       /* Specify how TypeScript looks up a file from a given module specifier. */
    // "baseUrl": "./",                                  /* Specify the base directory to resolve non-relative module names. */
    // "paths": {},                                      /* Specify a set of entries that re-map imports to additional lookup locations. */
    // "rootDirs": [],                                   /* Allow multiple folders to be treated as one when resolving modules. */
    // "typeRoots": [],                                  /* Specify multiple folders that act like `./node_modules/@types`. */
    // "types": [],                                      /* Specify type package names to be included without being referenced in a source file. */
    // "allowUmdGlobalAccess": true,                     /* Allow accessing UMD globals from modules. */
    // "resolveJsonModule": true,                        /* Enable importing .json files */
    // "noResolve": true,                                /* Disallow `import`s, `require`s or `<reference>`s from expanding the number of files TypeScript should add to a project. */

    /* JavaScript Support */
    // "allowJs": true,                                  /* Allow JavaScript files to be a part of your program. Use the `checkJS` option to get errors from these files. */
    // "checkJs": true,                                  /* Enable error reporting in type-checked JavaScript files. */
    // "maxNodeModuleJsDepth": 1,                        /* Specify the maximum folder depth used for checking JavaScript files from `node_modules`. Only applicable with `allowJs`. */

    /* Emit */
    // "declaration": true,                              /* Generate .d.ts files from TypeScript and JavaScript files in your project. */
    // "declarationMap": true,                           /* Create sourcemaps for d.ts files. */
    // "emitDeclarationOnly": true,                      /* Only output d.ts files and not JavaScript files. */
    // "sourceMap": true,                                /* Create source map files for emitted JavaScript files. */
    // "outFile": "./",                                  /* Specify a file that bundles all outputs into one JavaScript file. If `declaration` is true, also designates a file that bundles all .d.ts output. */
    // "outDir": "./",                                   /* Specify an output folder for all emitted files. */
    // "removeComments": true,                           /* Disable emitting comments. */
    // "noEmit": true,                                   /* Disable emitting files from a compilation. */
    // "importHelpers": true,                            /* Allow importing helper functions from tslib once per project, instead of including them per-file. */
    // "importsNotUsedAsValues": "remove",               /* Specify emit/checking behavior for imports that are only used for types */
    // "downlevelIteration": true,                       /* Emit more compliant, but verbose and less performant JavaScript for iteration. */
    // "sourceRoot": "",                                 /* Specify the root path for debuggers to find the reference source code. */
    // "mapRoot": "",                                    /* Specify the location where debugger should locate map files instead of generated locations. */
    // "inlineSourceMap": true,                          /* Include sourcemap files inside the emitted JavaScript. */
    // "inlineSources": true,                            /* Include source code in the sourcemaps inside the emitted JavaScript. */
    // "emitBOM": true,                                  /* Emit a UTF-8 Byte Order Mark (BOM) in the beginning of output files. */
    // "newLine": "crlf",                                /* Set the newline character for emitting files. */
    // "stripInternal": true,                            /* Disable emitting declarations that have `@internal` in their JSDoc comments. */
    // "noEmitHelpers": true,                            /* Disable generating custom helper functions like `__extends` in compiled output. */
    // "noEmitOnError": true,                            /* Disable emitting files if any type checking errors are reported. */
    // "preserveConstEnums": true,                       /* Disable erasing `const enum` declarations in generated code. */
    // "declarationDir": "./",                           /* Specify the output directory for generated declaration files. */
    // "preserveValueImports": true,                     /* Preserve unused imported values in the JavaScript output that would otherwise be removed. */

    /* Interop Constraints */
    // "isolatedModules": true,                          /* Ensure that each file can be safely transpiled without relying on other imports. */
    // "allowSyntheticDefaultImports": true,             /* Allow 'import x from y' when a module doesn't have a default export. */
    "esModuleInterop": true,                             /* Emit additional JavaScript to ease support for importing CommonJS modules. This enables `allowSyntheticDefaultImports` for type compatibility. */
    // "preserveSymlinks": true,                         /* Disable resolving symlinks to their realpath. This correlates to the same flag in node. */
    "forceConsistentCasingInFileNames": true,            /* Ensure that casing is correct in imports. */

    /* Type Checking */
    "strict": true,                                      /* Enable all strict type-checking options. */
    // "noImplicitAny": true,                            /* Enable error reporting for expressions and declarations with an implied `any` type.. */
    // "strictNullChecks": true,                         /* When type checking, take into account `null` and `undefined`. */
    // "strictFunctionTypes": true,                      /* When assigning functions, check to ensure parameters and the return values are subtype-compatible. */
    // "strictBindCallApply": true,                      /* Check that the arguments for `bind`, `call`, and `apply` methods match the original function. */
    // "strictPropertyInitialization": true,             /* Check for class properties that are declared but not set in the constructor. */
    // "noImplicitThis": true,                           /* Enable error reporting when `this` is given the type `any`. */
    // "useUnknownInCatchVariables": true,               /* Type catch clause variables as 'unknown' instead of 'any'. */
    // "alwaysStrict": true,                             /* Ensure 'use strict' is always emitted. */
    // "noUnusedLocals": true,                           /* Enable error reporting when a local variables aren't read. */
    // "noUnusedParameters": true,                       /* Raise an error when a function parameter isn't read */
    // "exactOptionalPropertyTypes": true,               /* Interpret optional property types as written, rather than adding 'undefined'. */
    // "noImplicitReturns": true,                        /* Enable error reporting for codepaths that do not explicitly return in a function. */
    // "noFallthroughCasesInSwitch": true,               /* Enable error reporting for fallthrough cases in switch statements. */
    // "noUncheckedIndexedAccess": true,                 /* Include 'undefined' in index signature results */
    // "noImplicitOverride": true,                       /* Ensure overriding members in derived classes are marked with an override modifier. */
    // "noPropertyAccessFromIndexSignature": true,       /* Enforces using indexed accessors for keys declared using an indexed type */
    // "allowUnusedLabels": true,                        /* Disable error reporting for unused labels. */
    // "allowUnreachableCode": true,                     /* Disable error reporting for unreachable code. */

    /* Completeness */
    // "skipDefaultLibCheck": true,                      /* Skip type checking .d.ts files that are included with TypeScript. */
    "skipLibCheck": true                                 /* Skip type checking all .d.ts files. */
  }
}

from gas-webpack-plugin.

fossamagna avatar fossamagna commented on May 30, 2024

@jpelton-stroud Thank you. I can reproduce the issue.
By changing autoGlobalExportsFiles glob pattern in webpack.config.js as follows, you will get the expected behavior.

    new GasPlugin({
      autoGlobalExportsFiles: ["**/*.ts"],
    }),

from gas-webpack-plugin.

joseffffff avatar joseffffff commented on May 30, 2024

Hi, I am having the same issue, seems the problem is that the compilation is wrapping all the compiled code in a function, and Google App Scripts needs to have doGet function on the top level of a file.

from gas-webpack-plugin.

fossamagna avatar fossamagna commented on May 30, 2024

@joseffffff Specify the Glob pattern for autoGlobalExportsFiles. * .ts does not cover ts files in nested directories. Try the ** / *.ts pattern.

from gas-webpack-plugin.

fossamagna avatar fossamagna commented on May 30, 2024

@jpelton-stroud Thanks for providing the example repository. I was able to reproduce this issue. I will investigate the cause.
By the way, I regenerated package-lock.json in example repo, because of it is include npm registory that I cannot access.

from gas-webpack-plugin.

fossamagna avatar fossamagna commented on May 30, 2024

@jpelton-stroud This issue occurs when the value of the target attribute in tsconfig.json is es3 (default value is es3). You can work around the problem by specifying es5. If you can't specify es5, you will need to wait to release fixed version of gas-webpack-plugin. In that case, it will take some time.

tsconfig.json:

{
  "compilerOptions": {
    "target": "es5", // add this line
    "lib": ["esnext"],
    "experimentalDecorators": true
  }
}

from gas-webpack-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.