Comments (10)
Just to follow up, foundation-rails
should be updated to depend on either sassc-rails
or sass-rails
. The difference is that the latter is just a thin wrapper around the former with template generation capability. From my understanding sass-rails
will stick around to support that case and to be maintained within the Rails organization.
from foundation-rails.
@jkimmeyer keep in mind ActiveAdmin may not be changing to sassc after all because it may not be necessary. The PR for that has updated info in comparison to the issue submitted. activeadmin/activeadmin#5504 (comment)
from foundation-rails.
@jkimmeyer @javierjulio Do you guys know if anyone is still maintaining this repo? Otherwise I'm going to fork it, switch the dependency to sassc and push a new version to RubyGems. Lemme know!
from foundation-rails.
Agreed, it would be nice to get an update on this issue, especially since PR #291 exists for it.
It appears that this gem is only receiving Foundation version updates, which are definitely welcome (thank you, maintainers ❤️ ), but it would be nice if some of these other issues could get a bit of attention as well.
from foundation-rails.
@pmichaeljones no need to do that dependency change: rails/sass-rails#424
from foundation-rails.
@javierjulio I'm a bit confused.
This repo is depending on sass spec.add_dependency "sass", [">= 3.3.0"]
The sass-rails gem is now a wrapper for sassc-rails gem, which is great, but if this repo is depending directly on the sass gem, then doesn't that still mean it's going to depend on an EOL library?
from foundation-rails.
Ah sorry. In that case it will have to update. I wonder though if this should just rely on sass-rails instead since this is a Rails asset gem.
from foundation-rails.
Relying on sass-rails, which is now just sassc-rails makes sense. Either way, our company site is still on Foundation 5 and doesn't plan on upgrading to 6, so I might just make a new gem for this issue.
from foundation-rails.
Any reason PR isn't accepted on this open issue?
Post-install message from sass:
Ruby Sass has reached end-of-life and should no longer be used.
* If you use Sass as a command-line tool, we recommend using Dart Sass, the new
primary implementation: https://sass-lang.com/install
* If you use Sass as a plug-in for a Ruby web framework, we recommend using the
sassc gem: https://github.com/sass/sassc-ruby#readme
* For more details, please refer to the Sass blog:
https://sass-lang.com/blog/posts/7828841
from foundation-rails.
this issue has still not been fixed 8 months after the end of life of the sass gem
from foundation-rails.
Related Issues (20)
- Chrome dev tool gets slow HOT 1
- trouble starting project HOT 1
- Responsive Navigation not working as expected in Rails 5.2
- Updating 6.5.1.0 require 'sprockets/es6' isn't working have to change to require 'sprockets/rails' HOT 3
- Slider Does is not draggable on iPad JS error HOT 3
- foundation.js asset is empty HOT 2
- rails 6.0.0.rc2 install issues HOT 18
- [invalid]
- orbit broken on 6.6.1.0, maybe by motion-ui HOT 2
- is-reveal-open and turbolinks HOT 4
- foundation-rails 6.3.1.0 breaks with Sprockets upgrade to 4.0.0 HOT 5
- Multiple `!global` assignments deprecation warnings on foundation-rails-6.6.2.0 HOT 4
- uninitialized constant Foundation::Rails::Generators
- Rails 6.1 - application.coffee does not appear to exist HOT 1
- How To include JS with webpacker?
- Updating from 6.4.3 to 6.5 HOT 2
- Maintained? HOT 3
- roles in dropdownmenu
- 91 Club Hack APK (100% Working) Download 2024
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from foundation-rails.