SEVERE: --via-r in combination with vm.warp break solidity execution and overrides stack variables about foundry HOT 4 CLOSED

Use vm.getBlockTimestamp and vm.getBlockNumber instead of block.number and block.timestamp when using via-ir mode, see here to learn more.

from foundry.

In a standard EVM environment, the block number and timestamp are constant in a transaction. Therefore the solidity compiler can use that assumption to optimize the bytecode it generates. However, in a forge test, the block number and timestamp are not constant. Therefore these assumption break, resulting in the bug you are seeing. If you replace block.number with vm.getBlockTimestamp you will see the tests works as expected.

In the comment I linked above, there is a link to a solidity issue where you can further discuss this with the solidity team.

from foundry.

@mds1 how is this not a bug?

The release time is stored in a variable.

So why does the emit return the wrong time, the only way this would be possible would be if vm.warp is overriding the stack variable.

from foundry.

ah you're saying a compiler optimization replaced the variable, with the reference, the memory was really references something else.

IMO, you should just depricate warp make a new function like vm.addTimestampSeconds() which just add seconds relative to the timestamp (same for the issue with roll), this way you encapsulate the reference to the block internally, and it will be more intuitive because it masks the edge case.

from foundry.