Support for Angular ~1.3.0 about angular-toastr HOT 30 CLOSED

It is not working? Give me some information.

from angular-toastr.

I don't get any errors on the console, it just doesn't show the popup messages. I am using latest version of angular and angular-animate (~1.3.0)

from angular-toastr.

It is not happening to me. The only difference is that in 1.3, toasts goes in a different direction. Something I have to resolve.

from angular-toastr.

http://plnkr.co/edit/nYsTDWTklBiwnLb8ciks?p=preview

from angular-toastr.

You were mixing there angular version beta.16 and the latest master animate, so it fails.

http://plnkr.co/edit/xujVY0Y0Qak5GJfn4aYc?p=preview

from angular-toastr.

ok I updated the version of both files to v1.3.0-build.3121+sha.a4520a7
http://plnkr.co/edit/nYsTDWTklBiwnLb8ciks?p=preview
It seems most likely to be a problem from angular and not your library.

from angular-toastr.

I downgraded the version to 1.3.0-beta.16 and seems to be working. Thanks!

from angular-toastr.

Seems to break again with 1.3.0-rc.0, they just don't show up at all (I'm using the same version between angular/animate/etc)

  ...
  "dependencies": {
    "normalize-css"    : ">=3.0.1",
    "angular"          : ">=1.3.0-rc.0",
    "angular-animate"  : ">=1.3.0-rc.0",
    "angular-route"    : ">=1.3.0-rc.0",
    "angular-resource" : ">=1.3.0-rc.0",
    "angular-toastr"   : ">=0.4.0",
    "lodash"           : ">=2.4.1",
    "ng-file-upload"   : ">=1.6.5",
    "ngQuickDate"      : ">=1.3.0",
    "selectize"        : ">=0.11.0",
    "ng-table"         : ">=0.3.3",
    "angular-ladda"    : ">=0.1.6"
  },
  ...

from angular-toastr.

can you do a bower list to check your angular and angular-animate versions?

from angular-toastr.

├── angular#1.3.0-rc.0
├─┬ angular-animate#1.3.0-rc.0
│ └── angular#1.3.0-rc.0
├─┬ angular-ladda#0.1.6
│ ├── angular#1.3.0-rc.0 incompatible with ~1.2.16 (1.2.24-build.428+sha.239d0b1 available, latest is 1.3.0-rc.0)
│ └─┬ ladda#0.9.4
│   └── spin.js#2.0.1
├─┬ angular-mocks#1.3.0-rc.0
│ └── angular#1.3.0-rc.0
├─┬ angular-resource#1.3.0-rc.0
│ └── angular#1.3.0-rc.0
├─┬ angular-route#1.3.0-rc.0
│ └── angular#1.3.0-rc.0
├─┬ angular-scenario#1.3.0-rc.0
│ └── angular#1.3.0-rc.0
├─┬ angular-toastr#0.4.0
│ └── angular#1.3.0-rc.0
├── lodash#2.4.1
├── ng-file-upload#1.6.5
├─┬ ng-table#0.3.3
│ └── angular#1.3.0-rc.0
├─┬ ngQuickDate#1.3.0
│ └── angular#1.3.0-rc.0 incompatible with ~1.2.0 (1.2.24-build.428+sha.239d0b1 available, latest is 1.3.0-rc.0)
├── normalize-css#3.0.1
└─┬ selectize#0.11.0
  ├── jquery#2.1.1
  ├── microplugin#0.0.3
  └── sifter#0.3.4

from angular-toastr.

You have to keep in mind that 1.3.x versions are unstable.
Try upgrading to version 1.3.0-beta.16

from angular-toastr.

Stupid question, but isn't that downgrading?

I do believe it works then (haven't tried it yet, but notifications used to work before I upgraded to rc1)

from angular-toastr.

You are correct, I meant downgrading

from angular-toastr.

Angular team is having a hard time with ngAnimate in versions 1.3.x, many issues are being reported. 1.3.0-rc.0 is an unstable version tho, I would recommend you to downgrade it in the meantime.

from angular-toastr.

Oh I gotcha, good thinking. Thanks!

from angular-toastr.

There is a breaking change on the RC-0. Basically a callback vs promise.

I need to think if I am going to release a version 0.5 to support only 1.3 and leave 0.4 for 1.2 or somehow try to support both.

WDYT?

from angular-toastr.

sounds good, support version 1.2 just for a while and drop it once version 1.3 reaches stabilization

from angular-toastr.

lmk if I can contribute somehow

from angular-toastr.

+1 for 1.3 support. Sweet module btw.

from angular-toastr.

When the 1.3 comes out I will release a new version which will break 1.2 compatibility.

For now, there are two $animate.enter on the code which uses a callback. Changing that to use a promise's then will solve the 1.3 problem.

from angular-toastr.

Would it make sense to branch off and implement that fix? Or just wait? I ended up just including toastr globally instead of in an angular.module. Seem's most angular-toaster libraries are broke in v.1.3.x

from angular-toastr.

1.3-rc.0 made a big BC on animations. Let me do the branch, that is easy to do.

from angular-toastr.

Alrighty, there is a 1.3 branch with the fix. It won't work with older versions of angular tho.

from angular-toastr.

👍 Thanks!

from angular-toastr.

New version, new release.

from angular-toastr.

so, is it the new version in the master branch?

from angular-toastr.

Yeah, version 0.5.1 is the good one.

from angular-toastr.

bower.json has version 0.3.0 on it, I think the code is the latest, just need to update the version :)

from angular-toastr.

Oh, true, damn bower, will fix that asap.

from angular-toastr.

ImI

from angular-toastr.