Logging infrastructure about sbctl HOT 6 OPEN

I want to implement these, just want to know what you think of the ideas in general.

from sbctl.

If you want to avoid the dependency, we only really need this:

// IsTerminal return true if the file descriptor is terminal.
func IsTerminal(fd uintptr) bool {
	_, err := unix.IoctlGetTermios(int(fd), unix.TCGETS)
	return err == nil
}

And it's MIT licensed too.

from sbctl.

I looked over the code and was a bit unsure if adding a dependency for this was needed indeed. I'd be comfortable with just having that function in the code and adding the dependency if we ever end up supporting other operating systems.

Rest of the plan sounds good. How the user facing looks can probably also be looked at. I like how fwupdmgr structures their output as an example

from sbctl.

I will be testing this out on my system for now, but do you know how I can attribute credit to that function? Wouldn't like to just take it.

from sbctl.

I'd use an SPDX header with a license, and link to the code repo along with any copyright info.

from sbctl.

Ok, thanks!

from sbctl.