Exit codes about sbctl HOT 3 OPEN

What exactly would the difference be between "invalid option" and "error in flags", if any?

Does verify return anything? We could have a flag for it to exit with an error if it finds any issues.

For sign, we could have a return value if the file doesn't exist.

Also in general, do you think the return value for error in configuration value could also be used for database errors, if they happen?

from sbctl.

I don't love this impl, and perhaps it makes more sense to do this with custom error types + logging, but something like

var (
	NoError          = 0
	NoRootError      = 1
	ConfError        = 2
	OptionError      = 3
	FlagError        = 4
	SignError        = 5
	BundleError      = 6
	MissingKeysError = 10
)

func ExitWithCode(e string, n int) {
	err.Print(e)
	os.Exit(n)
}

and then

func removeFileCmd() *cobra.Command {
	return &cobra.Command{
		Use:   "remove-file",
		Short: "Remove file from database",
		Run: func(cmd *cobra.Command, args []string) {
			if len(args) < 1 {
				sbctl.ExitWithCode("Need to specify file", sbctl.OptionError)
			}
			files := sbctl.ReadFileDatabase(sbctl.DBPath)
			delete(files, args[0])
			sbctl.WriteFileDatabase(sbctl.DBPath, files)
		},
	}
}

seems to work.

from sbctl.

I think it should be error based using errors.Unwrap(). Each error should map to an exit code with 1 being some unknown error.

Function will either need to changed to return errors or panic-defer-recover can be used.

from sbctl.