sbctl bundle splash image should detect if it's a valid bitmap file about sbctl HOT 13 CLOSED

Probably magick identify is a good tool for this.

from sbctl.

I'd prefer if we managed to write some Go code for this :) I dislike shelling out for tools and this could either be it's own library, find something already implemented or we make it a thing in go-uefi.

https://github.com/Foxboron/go-uefi

from sbctl.

Go based BMP decoder/encoder:

https://pkg.go.dev/golang.org/x/image/bmp

I dislike shelling out for tools

I also dislike spawning processes when a complex output parser is required but image magick exact output can be specified which makes parsing trivial.

from sbctl.

@Foxboron what do you think about temporary solution with magick identify.

It can be an optional dependency. If its not found on the system when a warning will be printed that splash image could not be verified.

from sbctl.

If we are only detecting the filetype pulling imagemagick is a bit much I think, we only really need to peek at 2 bytes in the file to see if it's a BMP (Example). But if you want to try and use more of the output to check towards the accepted image format then It's probably fine :)

from sbctl.

But if you want to try and use more of the output to check towards the accepted image format then It's probably fine

I will do that.

Imagemagick also verifies that the image is valid.

When should image check happen? In GenerateBundle ?

Should it instantly return error or just skip image?

from sbctl.

Maybe also check in bundle command?

from sbctl.

I think we can just do a hard failure in the bundle command when there is a file passed there :) No need for one in GenerateBundle as we should probably assume the values have been validated.

from sbctl.

How should lack of image magick be handled? Maybe print a warning that image could not be verified but proceed?

from sbctl.

If the file extension is not ".bmp" just say it can't be verified. Good enough I think

from sbctl.

I mean the magick command not the magic numbers.

from sbctl.

Yep, I got that :) But a simple fil extension check if fine if imagemagick is not available I think.

from sbctl.

I made initial check function but it far from finished: igo95862@577c182

from sbctl.