Comments (11)
Hi @ividyon, I have released the source code of the library under the MIT License, so I see no problem at all in using it.
However, I believe that the use of the word "Inspired" and the absence of a license notice in the README shows disrespect for the original library and its license.
In essence, you are asking that the README state the license and that you are using the code. The words Inspired or Evolution would be inappropriate in that context.
As I mentioned in one previous comment, I don't feel any respect for the original library. That would be the fundamental issue.
from promptplus.
hello. I'll be happy to put the terms you find necessary..... I never had the intention of violating anything... if you look at the code, there is a reference to the origin, it is not a copy, but an evolution. there is a huge difference.... that's why it's an inspiration... anyway what do you want to be cited and where?
from promptplus.
You write that you were inspired by the README, but in fact the implementation and testing of EastAsianWidth was simply copied from my original, so why don't you state that and the license in the README?
The EastAsianWidth and base-control was inspired by the work of Sharprompt
Don't forget that you have a history of using my library code almost verbatim and changing only the name to your own work for reasons of of evolution and inspiration.
from promptplus.
Hi @shibayan, I'd like to address this since, assumably, it shouldn't be a lot of work, and I don't believe there is negative intent here. People should be credited for their hard work as is needed. "Inspiration" is likely indeed not the right wording here, but I would err on the side of good faith and assume a reason like language barrier.
Since I'm not super familiar with the ins and outs of software licensing, what kind of PR would satisfy the conditions here? Do you have some pointers for me on what to change?
Particularly you mention "a history of using library code"; should more be attributed than just EastAsianWidth from Sharprompt?
from promptplus.
@FRACerqueira I notice that FIGlet.Net uses the GNU Affero license, which requires that any works using it must also use the same GNU Affero license as well. May I assume you have used FIGlet.Net code (and perhaps expanded on it) rather than just "being inspired"? In that case that is also a licensing issue, as PromptPlus would have to be a GNU Affero project.
You may re-implement the necessary code yourself so that it's a true inspiration, to avoid this.
from promptplus.
@FRACerqueira I notice that FIGlet.Net uses the GNU Affero license, which requires that any works using it must also use the same GNU Affero license as well. May I assume you have used FIGlet.Net code (and perhaps expanded on it) rather than just "being inspired"? In that case that is also a licensing issue, as PromptPlus would have to be a GNU Affero project.
You may re-implement the necessary code yourself so that it's a true inspiration, to avoid this.
I notice that library provides fairly minor benefits to PromptPlus, and is also a rewrite of a previous library which is under MIT:
https://github.com/auriou/FIGlet
Might be prudent to use that one instead.
from promptplus.
I made an according PR: #56
from promptplus.
@ividyon , Sorry for the delay, I was out of the office (Vacation). You did a great job on copyright. I intend to adapt the MIT version of "FIGlet" to PromptPlus following the same copyright notice model made by you.
from promptplus.
A commit to release v4.0.5 was performed on this issue.
@shibayan , I hope this is in line with the licensing wishes that have been requested.
Updated (19/10): Your EastAsia Width code (AND your tests) is being removed in the expected version (4.2.0)
If you still have another wish on this subject, or find a copy of code that does not mention your copywrite, just let us know and we will mention it accordingly. Thank you for contributing to the improvements!
from promptplus.
I think this can safely be closed.
from promptplus.
Hi @ividyon ! I hope you enjoyed the latest improvements.
I also think it is closed, but I am keeping it open with the tag "Closed issue" out of respect for the person who originated this issue to say that they agree or report any other changes that they do not agree with.
from promptplus.
Related Issues (20)
- Exception when try delete[F3] in empty colletion in AddTolist/AddtoMaskEditList control
- Edit[F2] Immutable item in AddTolist/AddtoMaskEditList control
- CTRL-V (paste data) does not show input in some controls
- Add TargetFramework .NET8
- Review method names for clarity
- Review EastAsia-Width function (Better understand how it works and research implementations) HOT 1
- Color Token accepts ':' to separate foreground color from background color
- Review Licences and Credits
- Add command Styles for custom color in the WaitProcess/WaitTime control
- Add global StyleSchema Ranger/Lines for custom color
- Add command HideRange to not show range in the Slider Control
- Add Styles command for custom colors on all controls
- Table control does not render correctly when it does not support Unicode
- Refinement of Unicode symbol rendering in all controls
- Optional value refinement for generic class
- Optimize the WaitControl control (for cancel correctly tasks)
- Remove Control Pipeline to use PipeAndFilter component
- PromptPlus output becomes messy from inside Parallel.ForEach or Parallel.Invoke functions HOT 4
- PromptPlus output ignores moved cursor position by asynchronous operations
- PromptPlus.WriteLine does not print stringified JSON HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from promptplus.