Cannot deploy a perseus app using beta.19 about perseus HOT 2 CLOSED

I'm willing to open a PR for this, I want to make sure I have the right idea because I didn't spend enough time in the project to understand what this code does. Here's my idea:

The trait MakeRx looks like this (without the doc comments):

pub trait MakeRx {
    type Rx: MakeUnrx;
    #[cfg(debug_assertions)]
    const HSR_IGNORE: bool = false;
    fn make_rx(self) -> Self::Rx;
}

Meaning HSR_IGNORE is available on types that implement the MakeRx trait only on debug builds.

But the functions get_frozen_state_and_register and get_frozen_global_state_and_register both have this condition:

if *is_hsr && S::HSR_IGNORE {
    return Ok(None);
}

Which has no guard to not be compiled in non-debug builds.

I would propose to simply guard either the full condition, or split it in order to prevent the compiler from tying to find HSR_IGNORE on non-debug builds.
Or perhaps HSR_IGNORE should be defined on all builds and in this case we would just remove it from the trait definition.

Please let me know, I'm willing to open a PR if it is a simple change (again because of my light understanding of what is actually going on there) or feel free to fix it quickly.

PS; I'm surprised something like this would not be picked up while trying to build the library in release mode, I haven't tried though.

from perseus.

Oh I'm an idiot, thank you very much, you're absolutely right. PR would be great! (I'll also check up on the CLI tests, which should have caught this...)

from perseus.