Giter VIP home page Giter VIP logo

Comments (9)

ammgws avatar ammgws commented on August 17, 2024 1

AFAIK when running on Windows, fish would just be running in something like cygwin or WSL where you cannot get the focused state of the app. However since this script also seems to work with tmux, perhaps on Windows notifications could still be sent when using tmux.

I don't seem to be getting any notifications from detached tmux windows on my linux machine, so first I will debug that and once it is working I will check using Windows and if successful can submit a PR for (limited) Windows support.

from done.

franciscolourenco avatar franciscolourenco commented on August 17, 2024

@jbucaran any idea what people on windows are using to display notifications?

from done.

jorgebucaran avatar jorgebucaran commented on August 17, 2024

@aristidesfl Not sure, but these couple of hits seem promising.

from done.

franciscolourenco avatar franciscolourenco commented on August 17, 2024

@jbucaran do you have any stats on the percentage of users on Windows?
Trying to evaluate if it would be worthwhile to work on this since I never use windows.

from done.

jorgebucaran avatar jorgebucaran commented on August 17, 2024

Definitely low. I think you can keep the issue open, but not make it a priority?

from done.

zhangnew avatar zhangnew commented on August 17, 2024

For wsl : microsoft/WSL#2466

PS C:\WINDOWS\system32> Install-Module -Name BurntToast

set -U __done_notification_command 'powershell.exe -command New-BurntToastNotification -Text WSL-ok'

from done.

franciscolourenco avatar franciscolourenco commented on August 17, 2024

@zhangnew do you have a proposal on how to integrate this in the package?

from done.

6A61736F6E206E61646572 avatar 6A61736F6E206E61646572 commented on August 17, 2024

If being run under WSL:

  • can detect if being run under WSL using grep Microsoft /proc/version
  • can detect if BurntToast is installed using powershell.exe -command Get-Module -Name BurntToast. (Need to figure out how to get the exit status from this command...)

However the biggest issue is detecting whether or not the terminal window is in the foreground.

from done.

ammgws avatar ammgws commented on August 17, 2024

Solved with #60.

from done.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.