Comments (9)
AFAIK when running on Windows, fish
would just be running in something like cygwin or WSL where you cannot get the focused state of the app. However since this script also seems to work with tmux
, perhaps on Windows notifications could still be sent when using tmux.
I don't seem to be getting any notifications from detached tmux windows on my linux machine, so first I will debug that and once it is working I will check using Windows and if successful can submit a PR for (limited) Windows support.
from done.
@jbucaran any idea what people on windows are using to display notifications?
from done.
@aristidesfl Not sure, but these couple of hits seem promising.
- http://stackoverflow.com/questions/12514475/how-can-you-create-pop-up-messages-in-a-batch-script
- http://stackoverflow.com/questions/774175/show-a-popup-message-box-from-a-windows-batch-file
from done.
@jbucaran do you have any stats on the percentage of users on Windows?
Trying to evaluate if it would be worthwhile to work on this since I never use windows.
from done.
Definitely low. I think you can keep the issue open, but not make it a priority?
from done.
For wsl : microsoft/WSL#2466
PS C:\WINDOWS\system32> Install-Module -Name BurntToast
set -U __done_notification_command 'powershell.exe -command New-BurntToastNotification -Text WSL-ok'
from done.
@zhangnew do you have a proposal on how to integrate this in the package?
from done.
If being run under WSL:
- can detect if being run under WSL using
grep Microsoft /proc/version
- can detect if BurntToast is installed using
powershell.exe -command Get-Module -Name BurntToast
. (Need to figure out how to get the exit status from this command...)
However the biggest issue is detecting whether or not the terminal window is in the foreground.
from done.
Solved with #60.
from done.
Related Issues (20)
- No notifications on debian 10 HOT 8
- Bad quotes in __done_humanize_duration? HOT 5
- Allow configuring urgency with notify-send for failed commands HOT 1
- tmux window detection broken in fish 3.2
- Did not work on Mac OS (11.4): ps: unsupported exe keyword HOT 5
- Ability to set notification timeout HOT 2
- Variable `$__done_notification_transient` is used but is not defined HOT 1
- Wrong parameter names in README HOT 2
- Consider joining Hacktoberfest HOT 2
- Unexpected and strange error "Unknown command: humanize_duration" HOT 7
- "basename: illegal option -- f" error when using with Tmux HOT 4
- Error messages: "error: process ID out of range" and "basename: missing operand" HOT 7
- How can I test if it's working? HOT 1
- Error printed after command finishes when terminal-notifier is not installed HOT 2
- Notifications not showing on Wayland due to focused window detection HOT 3
- macOS sound improvement HOT 4
- Not working on macOS 14.0 HOT 6
- Using tmux and terminal-notifier causes failure HOT 1
- Is it possible that this could cause Ghostty to hang on long running processes? HOT 11
- Long commands won't return in a root shell on macOS
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from done.