Comments (4)
I don't think this is a very big deal since the run
flag is mostly used for development purposes and not generally CI pipelines. In any case, we can always release a new major.
Would you like to open a PR so we can get this merged?
One thing that I believe it's missing here is to keep recursing all the way up until parent == nil
. Since you can have multiple nested describe
blocks: i.e:
Describe("Some", func() {
Describe("Little", func() {
Describe("Rabbit", func() {
It("jumps", func(){})
})
})
})
So the ultimate run
regex should target "Some.Little.Rabbit.jumps" and if I read the code correctly it's only targetting "Rabbit.jumps" given the current patch.
Additionally, does it make sense to concatenate the blocks with .
? Why not :
or any other char? I don't have any specific preferences here, just wondering if it's the best we can do about it.
from goblin.
I like this idea. Do we need a separate flag though? Why not just using the current run
flag and just change the current matchesRegex
line to use the GetFullName
function that you're proposing?
I don't think we're breaking backwards compatibility here, but just allowing to target Describe blocks as it's name
will be part of the regex target now.
from goblin.
@marcosnils
Using one flag would be better for sure, but i always think about those who already using this feature in their pipelines, don't want to break anything :)
from goblin.
I'd like to see this but concatenated with spaces to match Mocha's fullTitle()
behavior
from goblin.
Related Issues (20)
- Error output from testify doesn't use goblin theme HOT 1
- Test hooks should not execute if all tests are skipped HOT 3
- NotEqual assertions HOT 2
- How to run each test in parallel in test suite? HOT 5
- Is it expected, that Goblin doesn't output anything if all tests pass? HOT 2
- Request: Move Hosting of Images HOT 2
- Can't range over data set inside Describe block HOT 2
- Add support for mocking library HOT 6
- Dep ensures invalid version. HOT 1
- 0 not equal 0x0 HOT 1
- Regexp test selector does not seem to work. HOT 4
- basic error handle for incorrect use of the library HOT 2
- Table driven tests will test only last item HOT 4
- Allow multiple `errors` from failed test HOT 2
- Assertion redeclared during import w/ Gomega HOT 2
- Proposal: Please start using Semantic Versioning HOT 3
- Dependent Tests, skip some subset of tests if the parent test fails HOT 5
- IsNil (mis)behavior on pointers HOT 1
- Concurrency race when running in parallel
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from goblin.