I think update and render methods are inverted in the Engine constructor. Shouldn'

update and render inverted in the Engine about frankarendpoth.github.io HOT 4 CLOSED

frankarendpoth commented on July 19, 2024

update and render inverted in the Engine

from frankarendpoth.github.io.

Comments (4)

frankarendpoth commented on July 19, 2024

You mean the parameters are in the wrong order? I don't think it matters what order the parameters are in so long as they get used the right way.

from frankarendpoth.github.io.

jerome649 commented on July 19, 2024

Yes but in the rabbit trap source code the main files always contain

var engine = new Engine(1000/30, render, update);

So I think either render and update should be switch in engine constructor or each main files should be updated.

from frankarendpoth.github.io.

frankarendpoth commented on July 19, 2024

I see what you mean. It is inconsistent. Unfortunately the videos are already made and once the video is out I can't update the source code because it wouldn't be consistent with the video. That was something I decided going in. The lesser of two evils is to let whatever mistakes and inconsistencies be as they are and take solace in the fact that the example works, is logically sound, and matches the video. If the mistake is bad enough I make another project and another video to correct it. I've even removed entire projects. This doesn't seem quite that bad, however. Thanks for catching that, though. Keen eye.

…

On Fri, Nov 30, 2018, 9:30 PM jerome649 ***@***.*** wrote: Yes but in the rabbit trap source code the main files always contain var engine = new Engine(1000/30, render, update); So I think either render and update should be switch in engine constructor or each main files should be updated. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#4 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/APcmwrYECqEcuD4OidR5RJePFehEbxVUks5u0emogaJpZM4Y8m5x> .

from frankarendpoth.github.io.

frankarendpoth commented on July 19, 2024

I'm going to close this issue because the code is functional albeit inconsistent across different examples in the same project.

from frankarendpoth.github.io.

update and render inverted in the Engine about frankarendpoth.github.io HOT 4 CLOSED

Comments (4)

Related Issues (3)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent