Comments (8)
Hi @mildred, facing the same issue that the "Sales Payments" page does not show any entries after upgrade to 0.20.0
.
Wouldn't the proposed migration change the referenceType
for all Payments which currently have it null
to SalesInvoice
?
That would mean all the "Purchase Payments" would also show up in "Sales Payments" after the migration.
The offending commit changed filters for both the Payment types:
67f9232#diff-aa9c6d8495fb7b57d6dbc231fcf18a654ed1e4c98ed91739ebdb3e85e65e96ab
and the migration should also consider that and instead update the referenceType based on paymentType
field:
UPDATE Payment SET referenceType = 'SalesInvoice' WHERE paymentType = 'Receive';
UPDATE Payment SET referenceType = 'PurchaseInvoice' WHERE paymentType = 'Pay';
I might be wrong but this is what I could infer from taking a cursory look at the code.
from books.
Good point. I was under the impression that new payments since paymentType was introduced always filled the paymentType (since it was marked as required, it would have been a bug not to fill it).
So the migration not only needs to differenciate the paymentType as you suggest for existing payments, but also ensure that all future payments will not have a NULL paymentType.
from books.
Ready for release a fix soon in v0.20.1
from books.
Hi @18alantom!
I tried to replicate the issue above but wasn't able to.
Could you provide some more information about what version of FrappeBooks you are using along with what OS/OS-Version you are using?
Thanks!
from books.
I'm having the issue, but it seems the issue lies in the database, in the Payment
table the referenceType
column is empty.
from books.
This is probably a migration issue that removed this value. new payments do not have this problem.
from books.
This is 67f9232 that introduced the referenceType
column. The column value was marked as required but this prevented the migration to succeed so the required setting was removed and migrated payments now have a NULL value for referenceType
.
We should add a migration that run UPDATE Payment SET referenceType = 'SalesInvoice' WHERE referenceType IS NULL
from books.
The required was removed in 2d52ce8
from books.
Related Issues (20)
- Stock Balance and Stock Ledger both not loading. This error is for Stock Ledger HOT 2
- purchase payment option not shown HOT 1
- 🐛 [General Question] - Eliminate Electron HOT 4
- yarn dev/build results in dependencey errors. Unable to run application. : Could not resolve "source-map-support" HOT 1
- Where can I find documentation or swagger for the Books API? Does it have a REST API? HOT 1
- 🐛 [Bug] - When I use Chinese language, Chinese in csv file exported is garbled HOT 3
- Error when loading DB generated from other user account in the same computer
- FRAPPEBOOKS ONLINE VERSION HOT 2
- this error apper when i click on the database to open it
- 🐛 [Bug] BUILD FAILED - if i run exe file, Not showing anything after yarn build (windows) HOT 1
- Inventory does not work. HOT 2
- 🐛 [Bug] - <Content Area too small/unreadable on my 4K monitor. No resize interface found.>
- re Printing to Printer Function HOT 1
- Help Link Opens Invalid URL
- 💡 [Feature Request] - Remote DB integration HOT 1
- 💡 [Feature Request] - Payment reminder / Dunning
- Help in Frappe Books HOT 2
- 🐛 [Bug] - Can't create Sales Invoice from Sales Quote
- 🐛 [Bug] - Wrong action name is displayed in Purchase Receipt
- "Help" and links to "Documlentation" in App are loading to an invalid web page HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from books.