Giter VIP home page Giter VIP logo

Comments (2)

AidanSun05 avatar AidanSun05 commented on July 20, 2024

Thanks for reporting this. You are correct on how the TBA key is visible to the user. Because Black Hawks Scouting runs entirely in the user's browser, there's no way to completely block the user from accessing the key.

Before publishing the app, I had similar thoughts about this problem. While completely hiding the key is infeasible, it's still possible to put it "deeper" within the app to deter most users from finding it. The app uses the "standard obfuscation techniques" (GitHub Secrets and .env files) mentioned in the readme to isolate the key from the code in the repository. Therefore, the key can only be viewed with the browser's tools, and after the app is deployed. (For comparison, many other open source scouting apps I saw at the time had the key embedded directly in the source code.)

To make sure this wouldn't violate any TBA rules, I had contacted The Blue Alliance support and asked about this situation. Part of their response was:

There are spreadsheets and other projects that have TBA API keys published in them, and we don't see people lifting them and using them for harm. It sounds like the level of obfuscation you have would be good enough to prevent someone from lifting your key.

With all this, I made sure to emphasize security in the readme while keeping it concise. That's why that section says the key is "more difficult to find", but not "impossible to find".

Of course, if you find that part to be misleading or inaccurate, I'll be glad to change it.

from blackhawks-scouting.

AidanSun05 avatar AidanSun05 commented on July 20, 2024

I've updated the security section of the readme; I did find it to be lacking in information. I've added some details from my comment above to clarify the intent and limitations of the key-hiding feature. If you have any feedback on the revision, let me know.

from blackhawks-scouting.

Related Issues (4)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.