Giter VIP home page Giter VIP logo

Comments (3)

a2937 avatar a2937 commented on May 22, 2024

I believe I spotted the existing Playwright test for the donation modal.

There is the modal body itself that appears to need a fair bit of tests like the animation, the bear block completion illustration, the rows, the confirmation, and the header. Is this something I should consider working on in this file?

from freecodecamp.

huyenltnguyen avatar huyenltnguyen commented on May 22, 2024

@a2937 That's my least favorite modal (because of its complexity), so feel free to look into it 🙂 I think we can use that donate-page-default.spec.ts file for donation-modal's tests.

Just a note: If you need to add new tests, try to avoid the getByTestId() locator as much as possible. getByRole(), getByLabel(), and getByText() should be sufficient in most cases.

Here is our guide to working with Playwright: https://contribute.freecodecamp.org/#/how-to-add-playwright-tests.

from freecodecamp.

huyenltnguyen avatar huyenltnguyen commented on May 22, 2024

Closing this issue as we have decided to incorporate tests in the migration work, rather than making the changes in phases.

The tests will be part of #52759.

from freecodecamp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.