`make build` fails on Mac about sunder HOT 7 CLOSED

Ansible version: use ansible>=2.2.1. (Best practice is not lower than 2.2.1, due to CVE-2016-9587.) Consider tossing a requirements file ansible/ and setting it there.

Let's keep an eye on making the docs clear as possible. I've been using make build on Linux, to build the deb packages in a Vagrant VM, but to build on Mac I run npm run dist within the host Mac environment. That means you'll need to manage NodeJS versions manually, which I don't look forward to, but haven't found a smarter way.

from sunder.

Just realized I was running this with my system installation of Ansible 1.9.4, and it occurs to me that this bug might be due to an insufficiently new version of Ansible. @conorsch Do you have any idea what the minimum recommended version of Ansible for running make build is? I'm happy to take on the work of documenting it in the README.

from sunder.

Hm; since the original failure was a task in the external geerlingguy.nodejs playbook, I checked there first. According to their meta/main.yml, their min_ansible_version is 1.9, but I encountered the bug in the top comment while trying to run it with Ansible 1.9.4.

After creating a virtualenv for sunder and installing the latest version of Ansible (2.3.1.0), I was able to get past the failure in the Create npm global directory task. So it seems like we might need to require an Ansible version > 1.9.4 <= 2.3.1.0.

geerlingguy/ansible-role-nodejs#66 also seems related.

from sunder.

Ok, I got past the Create npm global directory task failure by using Ansible 2.3.1.0, but now I am encountering a different error. The output is a mess, but the key part appears to be: Unhandled rejection Error: Icon set directory /vagrant/build/icons doesn't exist. @GabeIsman Does that ring any bells? I'll take a look as well since I'm trying to wrap my head around the current build process so this doesn't all have to be resolved by you 😺 .

from sunder.

That sounds like Ansible isn't creating the parent directory correctly, will try to reproduce on a fresh clone.

Keep in mind that building in the Vagrant VM is only relevant for creating .deb packages, not .dmg files for installing on Mac.

from sunder.

@conorsch Good to know! Nonetheless, I'd like to/should be able to build both Mac packages and .deb packages and it seems like our dev/build process is in need of some QA at the moment.

from sunder.

Yup, that was the problem. PR incoming.

from sunder.