Giter VIP home page Giter VIP logo

Comments (2)

fregante avatar fregante commented on May 18, 2024

Thanks, Radu. Unfortunately there are a few issues:

  • it could be as simple as textarea.form.submit.click() for <textarea> fields (like in WordPress' theme-editor.php page), but support for complex javascript editors and non-standard forms is more complicated
  • how do we tell the user that this functionality might work on the current site or that it doesn't?
  • supporting this means breaking the save functionality in the text editor.
  • once you "save" the file, the form is sent, page reloads and GT connection is lost, so you might as well switch to the browser and click on the [Save] button yourself.

So while it may be feasible, it's not practical and introduces more issues.

Were you hoping to use this for the wp-admin/theme-editor.php page or in the post editor page (wp-admin/post-new.php)?

from ghosttext.

Cacodaimon avatar Cacodaimon commented on May 18, 2024
  • it could be as simple as textarea.form.submit.click() for <textarea> fields (like in WordPress' theme-editor.php page), but support for complex javascript editors and non-standard forms is more complicated

As long the code editor is nested into the right form this should be no problem, otherwise remote submission would be disabled.

  • how do we tell the user that this functionality might work on the current site or that it doesn't?

If the input area is nested into a from tag we could show the user if remote submitting is available or not.

  • supporting this means breaking the save functionality in the text editor.

Yes "overriding" the on save would be a bad idea but whats about a extra keyboard shortcut for submitting forms.

  • once you "save" the file, the form is sent, page reloads and GT connection is lost, so you might as well switch to the browser and click on the [Save] button yourself.

I only can agree with you!

So while it may be feasible, it's not practical and introduces more issues.

I'm not afraid about the issue but the practical reason is not clear at the moment.

from ghosttext.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.