Giter VIP home page Giter VIP logo

Comments (1)

leandro-lucarella-frequenz avatar leandro-lucarella-frequenz commented on June 12, 2024

After trying an implementation for this, we come to realize that it doesn't make a lot of sense.

It is actually weird to call receive() and get an exception that is triggered from the other end and it is not really a problem with receive() itself. When we thought about this feature, we were thinking about the PowerDistributor Responses:

https://github.com/frequenz-floss/frequenz-sdk-python/blob/4ce090ce32f539014101f145e8f97fc67990fa9e/src/frequenz/sdk/power_distribution/utils.py#L45-L69

But the problem with that response is that many response types are condensed into one class. What users should (probably) do instead is having a response class hierarchy or using type unions and have different response types as different Python types. For example:

Response = Union[Success, Ignored, Failure, ...]

Or

classDiagram
  Response <|-- Success
  Response <|-- Error
  Error <|-- OutOfBounds
  Response <|-- Ignored
  Response <|-- Failure

The channel then can have type Response, and when receiving responses, for older Python versions isinstance() can be used. For Python 3.10+ the match statement is the perfect fit for this:

match await receiver.receive():
    case Success:
        # all good
    case (Failure as failure):
        # Use failure
    case Error(error_message=msg):
        print(f"Error received: {msg}")
    ...
    case _:
        # Unknown response!

from frequenz-channels-python.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.