Comments (4)
This will be probably dropped because of the issues mentioned in:
from frequenz-channels-python.
I was just reading about the Select
implementation in go again, and realized that when there are multiple receivers ready, it picks one at random, and doesn't allow us to prioritize.
Now that I've thought about it further, I think that's how it should be, and is the true async way. So maybe we should revisit the ideas in #27.
I feel it might be useful to look into what other languages do as well.
Does that make sense?
from frequenz-channels-python.
I am not sure why would we want to not allow the user to prioritize what to process first if there are multiple receivers ready. 🤔
If it is some sort of safety (prevent starvation), maybe that should be an option?
async for receiver in select.one_by_one():
if receiver is x:
pass
In any case (I mean if we went with a one receiver at the time) I would still prefer to offer an async iterator interface rather than the less pythonic while
loop.
We could decide which one should be default, but removing options from the user doesn't seem like a good idea to me.
About looking at other languages, sure!
from frequenz-channels-python.
OK, now that I went though your new comments in the PR I have a better feeling for the starving issue and I think I'm starting to lean towards reviving #27 too. I created a new issue about that:
from frequenz-channels-python.
Related Issues (20)
- Improve composability of receivers HOT 4
- `FileWatcher` should expose more `awatch` configuration options
- Write introductory documentation
- Many class attributes should be private or read-only
- Consolidate and make channels `name`s (`client_id` / `service_id`) optional
- Remove `Peekable`
- Remove `Bidirectional`
- Remove `MergeNamed`
- Expose `Merge` as a `merge()` function
- `Receiver.map()` doesn't preserve the original receiver's type HOT 8
- Backport timer `reset()` fix to v0.16 HOT 2
- `Timer`: Remove `periodic()` and `timeout()`
- Filewatcher is not reporting events in CIFS mounts HOT 3
- Documentation and code cleanup for 1.0 HOT 1
- Remove uses of `BaseException`
- Find a way to make using select less likely to starve a receiver HOT 1
- Channel that doesn't remove the oldest messages when receiver buffer is full HOT 2
- Implement `SyncSender` and `AsyncSender` HOT 5
- Add a periodic timer
- Refactor event type and initialization in FileWatcher
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from frequenz-channels-python.