Is it intentional that there are no FK between these two tables? Right now if user get

I think that there should be FK with SET NULL for <co

Fixed in <a class="issue-link js-issue-link" data-error-text="Failed to load title" da

No foreign key between post_votes and users table about gamification HOT 4 CLOSED

friendsofflarum commented on July 26, 2024

No foreign key between post_votes and users table

from gamification.

Comments (4)

clarkwinkelmann commented on July 26, 2024

I think this might be intentional.

The hotness of discussions is calculated from that table, so deleting a user would cause a discussion to drop in the hotness ranking.

gamification/src/Vote.php

Lines 77 to 82 in 54db432

 public static function updateDiscussionVotes(Discussion $discussion): Discussion 

 { 

 $discussion->votes = self::calculate(['post_id' => $discussion->first_post_id]); 

 return $discussion; 

 }

We should probably clarify that it is the intended behavior in the source code if we are ok with this.

from gamification.

rob006 commented on July 26, 2024

I think that there should be FK with SET NULL for ON DELETE - it will be clear that this is intended behavior. Right now leaving orphaned IDs in user_id looks like an oversight.

from gamification.

clarkwinkelmann commented on July 26, 2024

That makes sense 👍

from gamification.

imorland commented on July 26, 2024

Fixed in #93

from gamification.

No foreign key between post_votes and users table about gamification HOT 4 CLOSED

Comments (4)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	public static function updateDiscussionVotes(Discussion $discussion): Discussion
	{
	$discussion->votes = self::calculate(['post_id' => $discussion->first_post_id]);

	return $discussion;
	}