Giter VIP home page Giter VIP logo

Comments (4)

clarkwinkelmann avatar clarkwinkelmann commented on May 20, 2024

I'm not sure I understand what you're asking.

By default fields are visible in the user's Masquerade tab.

When "show in bio" is enabled, the field is ALSO shown on the user card.

I don't think there is currently any logic to show/hide fields that have been filled or not.

from masquerade.

arteteco avatar arteteco commented on May 20, 2024

I'm asking to add the feature to hide empty fields, they look especially bad under the bio

Sorry if that part gave you some confusion in understanding the issue, actually it wasn't necessary!

from masquerade.

rafaucau avatar rafaucau commented on May 20, 2024

@clarkwinkelmann It looks bad on a user's profile when someone browses their profile and sees a bunch of blank fields.
image
And if none of the fields are completed, a placeholder should appear.

If displaying blank fields is not intended in this extension then I can do a PR.

from masquerade.

clarkwinkelmann avatar clarkwinkelmann commented on May 20, 2024

No choice has been made on how to handle this issue so far.

I think my preferred solution would be to apply a className to the fields so that forum owners can customize how empty fields should look like visually, by either adding "Empty" text in pseudo-elements, or hiding the field completely.

If we start adding options to customize the look, I fear we won't know where to stop. If we add an option for this, there will be requests for other customization, and where should we stop. Likewise it would be nice to be able to customize vertical vs horizontal layout for labels+value, but I feel like it might be too much to have that as an option and would be better for custom CSS.

The UI is pretty poor by default, so I wouldn't be against a new default design (CSS, but might also require changes to markup) to give it a more engaging look.

In any case I don't think we should force hiding the fields as some people will want to show empty fields.

from masquerade.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.