Consider targetting .NET 6 as well about fsharp.formatting HOT 8 CLOSED

Available in https://www.nuget.org/packages/fsdocs-tool/18.0.0

from fsharp.formatting.

Hello,

Thank you for bringing this up. This may not be possible because we depend on MSBuild bits for project cracking. @baronfel any thoughts?

from fsharp.formatting.

I think it's possible but we need to set the Microsoft.Build to copy_local: false.

# copy_local: false excludes runtime assets (desired for msbuild)
nuget Microsoft.Build copy_local: false
nuget Microsoft.Build.Framework copy_local: false
nuget Microsoft.Build.Utilities.Core copy_local: false
nuget Microsoft.Build.Tasks.Core copy_local: false

ionide/proj-info#178

from fsharp.formatting.

We would first need to have #796 right?
As our current version of FCS would pull down those dependencies anyway.

from fsharp.formatting.

We would first need to have #796 right? As our current version of FCS would pull down those dependencies anyway.

I don't think we need it for just this. The dependencies for Ionide.ProjInfo.FCS are FSharp.Compiler.Service(>= 41.0.5)

from fsharp.formatting.

Yeah, until you actually install it.
Tried this console app:

<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <OutputType>Exe</OutputType>
    <TargetFramework>net7.0</TargetFramework>
    <RootNamespace>oh_jimmy</RootNamespace>
     <RestorePackagesWithLockFile>true</RestorePackagesWithLockFile>
  </PropertyGroup>

  <ItemGroup>
    <Compile Include="Program.fs" />
  </ItemGroup>

  <ItemGroup>
  <PackageReference Include="Ionide.ProjInfo.FCS" Version="0.61.2" />
  <PackageReference Update="FSharp.Core" Version="6.0.5" />
</ItemGroup>
</Project>

Lock file says:

      "FSharp.Compiler.Service": {
        "type": "Transitive",
        "resolved": "41.0.5",
        "contentHash": "p88YDZYJCnuQRqnWnN9kcklHzEVy0vEEnjZ0e+/fszAASEInoAzkfs4SxTTrgsw7ey+hmbkjYjvcbC8Ed1Xa4Q==",

and build output looks like:

I do think we need the latest FCS to get around that problem.

When I add:

  <PackageReference Update="FSharp.Core" Version="7.0.200" />
  <PackageReference Include="FSharp.Compiler.Service" Version="43.7.200" />

I don't get those MSBuild dlls.

from fsharp.formatting.

Oh because this project is on 42.7.101, yep, we need to get off that version. (Wonder if they should unlist it?)

from fsharp.formatting.

And looks like this project doesn't need Ionide.ProjInfo.FCS, just Ionide.ProjInfo and Ionide.ProjInfo.Sln so that's good.

from fsharp.formatting.