Not able to install adlfs through pip about adlfs HOT 12 CLOSED

It seems like the import in the setup.py file doesn't recognize the versioneer.py file.

from adlfs.

from adlfs.

You should not normally need versioneer in your environment - only the person creating the package needs it. Versioneer is self-contained in the massive file that gets added to the repo. Perhaps it is missing in MANIFEST?

from adlfs.

@hayesgb

1. Yes, I am working in a conda env.
2. Windows10 but the issue also appears on Ubuntu 16 (tested locally and in azure pipelines)
3. No. Then it complains about the get_version() call in setup.py and as @martindurant says, I shouldn't need it right?

I just verified it installs with pip into a fresh conda environment on Python 3.7. A few questions: 1) Are you working in a conda environment? If not, are you using pipenv? 2) What OS are you working on? 3) If you pip install versioneer into your environment, can you then pip install adlfs? Thanks, Greg
…
On Dec 16, 2019, at 6:20 AM, Sebastian Liljevall @.***> wrote: It seems like the import in the setup.py file doesn't recognize the versioneer.py file. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#28?email_source=notifications&email_token=ADADBNQ72AM5AVSNE5HSYCLQY5XCPA5CNFSM4J3I3AYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEG6Q5PY#issuecomment-566038207>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADADBNTCCVQHLDRD6LXU45LQY5XCPANCNFSM4J3I3AYA.

from adlfs.

Agree, it shouldn't be needed.

My install is using the following in a clean conda environment:
conda == 4.7.12
pip == 19.3.1
Python = 3.7.3
MacOS

A similar error with versioneer was reported here earlier this year, which was attributed to pip and possibly PEP517. Here they recommend installing with pip install --no-use-517 pandas.

Can you try that with adlfs?

from adlfs.

Tested, still the same error: "No module named 'versioneer'"

from adlfs.

@martindurant -- Any chance you can replicate? I'm not having any luck. It also runs passes the tests in Azure Pipelines.

@sebastianpantin - Can you verify your conda version?

from adlfs.

Hello,

Same issue on Ubuntu 18.04 in a virtual env

• python 3.6.9
• pip 19.3.1

$ pip install adlfs

Collecting adlfs
  Using cached https://files.pythonhosted.org/packages/a5/ae/9251819f30a0b28912bb9589305bf3cbd549487b98d277858049ea1be702/adlfs-0.1.4.tar.gz
    ERROR: Command errored out with exit status 1:
     command: /home/alexis/Documents/Projets/Sandbox/DaskAzurite/venv/bin/python3 -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-g6lmykoy/adlfs/setup.py'"'"'; __file__='"'"'/tmp/pip-install-g6lmykoy/adlfs/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-install-g6lmykoy/adlfs/pip-egg-info
         cwd: /tmp/pip-install-g6lmykoy/adlfs/
    Complete output (5 lines):
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-install-g6lmykoy/adlfs/setup.py", line 5, in <module>
        import versioneer
    ModuleNotFoundError: No module named 'versioneer'
    ----------------------------------------
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.

Tried to install versioneer

pip install versioneer

but then got:

Collecting adlfs
  Using cached https://files.pythonhosted.org/packages/a5/ae/9251819f30a0b28912bb9589305bf3cbd549487b98d277858049ea1be702/adlfs-0.1.4.tar.gz
    ERROR: Command errored out with exit status 1:
     command: /home/alexis/Documents/Projets/Sandbox/DaskAzurite/venv/bin/python3 -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-8lto2ljt/adlfs/setup.py'"'"'; __file__='"'"'/tmp/pip-install-8lto2ljt/adlfs/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-install-8lto2ljt/adlfs/pip-egg-info
         cwd: /tmp/pip-install-8lto2ljt/adlfs/
    Complete output (5 lines):
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-install-8lto2ljt/adlfs/setup.py", line 10, in <module>
        version=versioneer.get_version(),
    AttributeError: module 'versioneer' has no attribute 'get_version'
    ----------------------------------------
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.

Installing from the git repository worked:

python setup.py install

from adlfs.

Indeed, the 0.1.4 tar-gz package does not include versioneer.py in the root as it should (only has _version.py within the inner python package). I suggest there should be an explicit MANIFEST file, or that it should otherwise be specified by the setup.py script.

from adlfs.

I don't really know versioneer but it just looks like a misuse of it.

I just followed the Quick Install instructions from versioneer github (the [versioneer] section being already there)

If after installing versioneer and applying

$ pip install versioneer
$ versioneer install

in the project directory. If I then build the packages

$python setup.py sdist bdist_wheel

The generated packages install without any problem even in an environment not having versioneer.

So maybe the person who generated the package forgot to install versioneer ?

from adlfs.

Yes, that's how it's supposed to work

from adlfs.

@martindurant, @alexis-mignon -- Thanks. I just pushed v0.1.5 to pypi, and verified that versioneer.py is in the tarball file. Not sure how I was able to successfully install from pypi on my machine, but a watch-out for the future.

from adlfs.