Misleading Exceptions about adlfs HOT 5 CLOSED

The only error I have seen in this block is a ResourceNotFound error. If we get back something else, we should probably raise a RuntimeError in this block, and propagate the error message {e} back to the user.

from adlfs.

I'd be happy to work on a PR if there is an agreement that this is an issue 😄

from adlfs.

Thanks @andersbogsnes . Agree this is an issue, and if you have some time to work on it that would be great.

However, I added one unit test (test_ls_0), which calls fs.ls("."), and if I
update the ls() method to simply allow the Exception to pass through, but this then causes some of the glob tests to fail. For the moment, I will leave the FileNotFoundError in place, but I've propagated this up to master with the test marked as xfail.

from adlfs.

Ran into some more issues with exceptions here: https://github.com/dask/adlfs/blob/07aabb7beea34b640c75991f07142154f8f39b3c/adlfs/core.py#L754

(It's trying to raise a string, which errors)

I'm working on a PR in my downtime, but was wondering if there's a need to introduce an exception hierarchy of some sort. Does fsspec have an opinion on that? What type of exception should be raised here?

from adlfs.

Closed on PR#72

from adlfs.