Potentially omitted :force-root in `schedule-render!` about fulcro HOT 5 CLOSED

Another observation: aren't debounce and sched/schedule-animation! overlapping functionality. At the first glance sched/schedule-animation! looks like throttle-first with a global state.

(debounce (throttle-first (fn [] ...) 16) 16)

Since the debounce encapsules sched/schedule-animation!, the latter is not going to do anything, unless sched/schedule-animation! with that particular action is also used somewhere else.

from fulcro.

Your problem report is not clear to me. Are you observing a condition where the UI is incorrect? Or are you reporting that you don't like it that render might be called more than you like?

from fulcro.

This issue is not about double rendering (which was initial reason for my investigation) but about shared props not being recalculated under certain conditions.

Please have a look at issue desc under section titled Problem with schedule-render!. I haven't try to reproduce it, but by reading the code, it looks that calling (schedule-render! app {:force-root? true}) is not guaranteed to honor :force-root? true, meaning when we request force shared props to be recalculated via schedule-render!, under certain conditions they might not get recalculated.

It is not my problem, but if I'm correct, it is a source of occasional issues related to shared props.

I don't have certainty that this is a problem, that is why I opened the issue to report it and listen what you say.

from fulcro.

In other words:

• (render! app {:force-root? true}) - recalculates shared props always
• (schedule-render! app {:force-root? true}) - most times recalculates shared props, sometimes not

from fulcro.

Thanks for the clarification. Your final message was much more consumer-friendly. Succinct and to the point is best.

I agree with your assessment. Schedule render will not accumulate options which will cause a forced-root to be missed. That said, a force root render really should only be used in two cases I can think of: ops like i18n change locale where props have not changed but re-render is necessary, and dev-time.

the i18n code should therefore do a manual render and not a scheduled one.

from fulcro.