Giter VIP home page Giter VIP logo

Comments (7)

asadsahi avatar asadsahi commented on May 20, 2024 1

Thanks for letting me know.

According to angular.io docs, testing guidelines aren't final yet, so I will hang on, before making changes as per RC5 in this project.

from aspnetcorespa.

chris-house avatar chris-house commented on May 20, 2024

Demo is down again. http://aspnetcorespa.azurewebsites.net/

Is there anything I can help work on?

from aspnetcorespa.

asadsahi avatar asadsahi commented on May 20, 2024

Hi @crh225 , thanks for the offer. Sure, there is always something which can be improved. :)

Few things pending are:

  1. Client unit tests
  2. Production build with webpack is broken since RC5 upgrade. Probably new angular compiler needs to bring in the mix. Not sure though, so this is something can be picked up as well.
  3. Server side unit tests.

Any other good idea? I am happy to accept any pull requests.

from aspnetcorespa.

chris-house avatar chris-house commented on May 20, 2024

@asadsahi, I don't know if there's any other way of asking my questions than through comments on issues, but what do the plus signs mean in the components? Is this something new in rc5, or just a convention you use?

from aspnetcorespa.

chris-house avatar chris-house commented on May 20, 2024

Accoring to http://stackoverflow.com/questions/38895087/tests-are-failing-after-angular-2-rc5, angular removed references to jasmine in @angular/core/testing

Need to install typings for jasmin globally: typings install jasmin --source dt --global

all spec files need to be changed apparently. beforeEachProviders becomes beforeEach, and we need to remove the unnecessary imports.

When I got kamra working, four of the tests were failing, but I fixed those.

I have fixed all the tests and am creating a pull request

from aspnetcorespa.

chris-house avatar chris-house commented on May 20, 2024

Issue is fixed in pull request: #5

from aspnetcorespa.

asadsahi avatar asadsahi commented on May 20, 2024

@crh225 thanks for helping. I have merge the pull request.

plus signs are conventions to prefix folder with modules which will be lazily loaded as explained in angular 2 guidelines here.

from aspnetcorespa.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.