Comments (7)
Thanks for letting me know.
According to angular.io docs, testing guidelines aren't final yet, so I will hang on, before making changes as per RC5 in this project.
from aspnetcorespa.
Demo is down again. http://aspnetcorespa.azurewebsites.net/
Is there anything I can help work on?
from aspnetcorespa.
Hi @crh225 , thanks for the offer. Sure, there is always something which can be improved. :)
Few things pending are:
- Client unit tests
- Production build with webpack is broken since RC5 upgrade. Probably new angular compiler needs to bring in the mix. Not sure though, so this is something can be picked up as well.
- Server side unit tests.
Any other good idea? I am happy to accept any pull requests.
from aspnetcorespa.
@asadsahi, I don't know if there's any other way of asking my questions than through comments on issues, but what do the plus signs mean in the components? Is this something new in rc5, or just a convention you use?
from aspnetcorespa.
Accoring to http://stackoverflow.com/questions/38895087/tests-are-failing-after-angular-2-rc5, angular removed references to jasmine in @angular/core/testing
Need to install typings for jasmin globally: typings install jasmin --source dt --global
all spec files need to be changed apparently. beforeEachProviders becomes beforeEach, and we need to remove the unnecessary imports.
When I got kamra working, four of the tests were failing, but I fixed those.
I have fixed all the tests and am creating a pull request
from aspnetcorespa.
Issue is fixed in pull request: #5
from aspnetcorespa.
@crh225 thanks for helping. I have merge the pull request.
plus signs are conventions to prefix folder with modules which will be lazily loaded as explained in angular 2 guidelines here.
from aspnetcorespa.
Related Issues (20)
- STS Project HOT 1
- README Missing Items Unable to Start Application HOT 3
- Identity Server Help HOT 1
- Dependency Issues - jquery, popper.js, Angular 6 HOT 1
- Identity server migration HOT 6
- local identity server invalid client error HOT 1
- login-redirect.html missing HOT 1
- ngbDate invalid in Dynamic Form Date Control HOT 4
- All User with Associated Roles HOT 1
- MAC verification failed during PKCS12 import HOT 1
- error in run HOT 2
- dotnet dev-certs HOT 2
- Swagger endpoint not available on deployed app HOT 1
- Template config for streams HOT 1
- AspNetCoreSpa with React Typescript HOT 1
- aspnetcorespa.fullstackpro.xyz is not reachable HOT 1
- Live site is broken HOT 1
- Unable to launch the application HOT 3
- Unable to run project
- Can't open home page HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aspnetcorespa.