off-by-one bug in ProjectionActor when using akka-persistence-jdbc about fun-cqrs HOT 5 CLOSED

Hi @vpavkin,

After some research, I have the impression that the error is on the plugin side.

I see the following on their source:

  def eventsByTag(tag: String, offset: Long): Query[Journal, JournalRow, Seq] =
    JournalTable.filter(_.tags like s"%$tag%").sortBy(_.created.asc).drop(offset)

  def eventsByTagAndPersistenceId(persistenceId: String, tag: String, offset: Long): Query[Journal, JournalRow, Seq] =
    JournalTable
       .filter(_.persistenceId === persistenceId)
       .filter(_.tags like s"%$tag%")
       .sortBy(_.sequenceNumber.asc)
       .filter(_.sequenceNumber >= offset)

In eventsByTag, they drop everything up to the offset (offset included).

In eventsByTagAndPersistenceId, they retain everything with sequenceNumber >= offset, thus offset included in the result.

The second is aligned with LevelDB and Cassandra plugin (and with our internal Postgres plugin as well).

The problem is that the query documentation is lacking and we don't have a TestKit yet.

Maybe @dnvriend can shed some light here.

from fun-cqrs.

@rcavalcanti Sorry for being silent for some time. I see what you mean, definitely makes sense.
I agree that the main problem here is the lack of precise persistent query spec. Thanks for digging the truth! :)

Luckily, a workaround here is rather simple. Feel free to close this issue. 👍

from fun-cqrs.

Hi @vpavkin,

I won't close this issue for the moment as I want to investigate better what are the plans for the query API. I want to investigate it further before reaching the Akka team.

from fun-cqrs.

hi @rcavalcanti.
Just upgraded my project to FunCQRS 0.4.6 and akka-persistence-jdbc 2.5.2.
Bug doesn't seem to reproduce any more.

from fun-cqrs.

Hi @vpavkin,

Nothing was added to on Fun.CQRS with respect to that. I think the fix comes from akka-persistence-jdbc 2.5.2.

I have saw some tweets from @dnvriend with the akka team discussing about the TestKit for akka persistence query. He may get involved with it.

I'll close this issue therefore.

from fun-cqrs.