Plugin fails starting from Serverless v2.5.0 about serverless-iam-roles-per-function HOT 26 CLOSED

@theburningmonk @randomhash @andersquist @Enase thanks for offering your help. Really appreciated. I've added you to the repo with write access. So you will be able to approve and merge PRs.

Additionally, I've just deployed a pre-release of version 3.0.0 with the latest merged PRs: https://www.npmjs.com/package/serverless-iam-roles-per-function/v/3.0.0-d84bffd

I am also looking into automating the deployment process so at least for the next we will get an auto deploy once merged to master.

from serverless-iam-roles-per-function.

Ran into this issue as well.
We were able to find a temporary workaround by locking the version of serverless framework installed to a previous version.
npm i [email protected] -g

from serverless-iam-roles-per-function.

I've fixed the builds and failing tests for the PR and the package as a whole. If anyone feels inclined to review the PR I'd be so happy. 🙏

Meanwhile I've published a temporary package under the innovative name of serverless-iamroles for my own purposes with these fixes incorporated. Until this gets fixed/merged be happy to use it if you like:
https://www.npmjs.com/package/serverless-iamroles

from serverless-iam-roles-per-function.

@glicht I'm happy to help out. I depend on this project a lot.

from serverless-iam-roles-per-function.

Use this :
"serverless-iam-roles-per-function": "2.0.2",

from serverless-iam-roles-per-function.

Was this fixed @theburningmonk ?

from serverless-iam-roles-per-function.

Master version specifies no lock on the version (https://github.com/functionalone/serverless-iam-roles-per-function/blob/master/package.json). Is this on purpose?

"serverless": "^1.51.0",

Therefore if any breaking changes are introduced, say from 2.4.0 to 2.5.0, you will have to deal with that.

from serverless-iam-roles-per-function.

any updated?

from serverless-iam-roles-per-function.

@glicht Hello. Also would be glad to help. Heavily dependable on this project

from serverless-iam-roles-per-function.

@glicht The same here! 🙂

from serverless-iam-roles-per-function.

Just ran into the same issue!

from serverless-iam-roles-per-function.

facing the same problem here as well

Serverless: Packaging service...
Serverless: Excluding development dependencies...
Serverless: Excluding development dependencies...
Serverless: Injecting required Python packages to package...

  Type Error ---------------------------------------------

  TypeError: this.awsPackagePlugin.validateStatements is not a function
      at ServerlessIamPerFunctionPlugin.validateStatements (/Users/rijwan/code/g2g/serverless-python-order/node_modules/serverless-iam-roles-per-function/src/lib/index.ts:62:27)
      at ServerlessIamPerFunctionPlugin.createRoleForFunction (/Users/rijwan/code/g2g/serverless-python-order/node_modules/serverless-iam-roles-per-function/src/lib/index.ts:209:10)
      at ServerlessIamPerFunctionPlugin.createRolesPerFunction (/Users/rijwan/code/g2g/serverless-python-order/node_modules/serverless-iam-roles-per-function/src/lib/index.ts:306:12)
      at /Users/rijwan/.nvm/versions/node/v12.18.4/lib/node_modules/serverless/lib/classes/PluginManager.js:510:55
      at tryCatcher (/Users/rijwan/.nvm/versions/node/v12.18.4/lib/node_modules/serverless/node_modules/bluebird/js/release/util.js:16:23)
      at Object.gotValue (/Users/rijwan/.nvm/versions/node/v12.18.4/lib/node_modules/serverless/node_modules/bluebird/js/release/reduce.js:168:18)
      at Object.gotAccum (/Users/rijwan/.nvm/versions/node/v12.18.4/lib/node_modules/serverless/node_modules/bluebird/js/release/reduce.js:155:25)
      at Object.tryCatcher (/Users/rijwan/.nvm/versions/node/v12.18.4/lib/node_modules/serverless/node_modules/bluebird/js/release/util.js:16:23)
      at Promise._settlePromiseFromHandler (/Users/rijwan/.nvm/versions/node/v12.18.4/lib/node_modules/serverless/node_modules/bluebird/js/release/promise.js:547:31)
      at Promise._settlePromise (/Users/rijwan/.nvm/versions/node/v12.18.4/lib/node_modules/serverless/node_modules/bluebird/js/release/promise.js:604:18)
      at Promise._settlePromise0 (/Users/rijwan/.nvm/versions/node/v12.18.4/lib/node_modules/serverless/node_modules/bluebird/js/release/promise.js:649:10)
      at Promise._settlePromises (/Users/rijwan/.nvm/versions/node/v12.18.4/lib/node_modules/serverless/node_modules/bluebird/js/release/promise.js:729:18)
      at _drainQueueStep (/Users/rijwan/.nvm/versions/node/v12.18.4/lib/node_modules/serverless/node_modules/bluebird/js/release/async.js:93:12)
      at _drainQueue (/Users/rijwan/.nvm/versions/node/v12.18.4/lib/node_modules/serverless/node_modules/bluebird/js/release/async.js:86:9)
      at Async._drainQueues (/Users/rijwan/.nvm/versions/node/v12.18.4/lib/node_modules/serverless/node_modules/bluebird/js/release/async.js:102:5)
      at Immediate.Async.drainQueues [as _onImmediate] (/Users/rijwan/.nvm/versions/node/v12.18.4/lib/node_modules/serverless/node_modules/bluebird/js/release/async.js:15:14)
      at processImmediate (internal/timers.js:456:21)

     For debugging logs, run again after setting the "SLS_DEBUG=*" environment variable.

  Get Support --------------------------------------------
     Docs:          docs.serverless.com
     Bugs:          github.com/serverless/serverless/issues
     Issues:        forum.serverless.com

  Your Environment Information ---------------------------
     Operating System:          darwin
     Node Version:              12.18.4
     Framework Version:         2.5.0
     Plugin Version:            4.0.4
     SDK Version:               2.3.2
     Components Version:        3.2.1

from serverless-iam-roles-per-function.

It's a critical bug for community that might be fixed in one click (and later you may implement the correct solution). why not?

from serverless-iam-roles-per-function.

I've fixed the builds and failing tests for the PR and the package as a whole. If anyone feels inclined to review the PR I'd be so happy. pray

Meanwhile I've published a temporary package under the innovative name of serverless-iamroles for my own purposes with these fixes incorporated. Until this gets fixed/merged be happy to use it if you like:
https://www.npmjs.com/package/serverless-iamroles

@glicht Would also enormously appreciate it if you guys could merge this PR :)

from serverless-iam-roles-per-function.

@davidfells the first warning is b/c Serverless validates serverless.yml and doesn't know about custom properties this plugin relies onto. So ignore it. It's expected to see that warning.

Regarding the 2n error, it has nothing to do with this plugin either. 1st result in Google yielded this - https://stackoverflow.com/a/51728883/2727317

And it applies to your config. You're using #{AWS::AccountId} to substitute account id. But I don't see you have https://www.serverless.com/plugins/serverless-pseudo-parameters/ plugin in your config....

from serverless-iam-roles-per-function.

On the warning, thanks.

Not sure how I lost my pesudo parameters plugin and didn't catch it in Git, but adding it back resolved the issue. Thanks again.

from serverless-iam-roles-per-function.

I am experiencing this issue as well.

from serverless-iam-roles-per-function.

@amitpn805 it will fail for 2.5.0

use 2.4.0< version of serverless for now

from serverless-iam-roles-per-function.

Same issue here this.awsPackagePlugin.validateStatements is not a function

Use this :
"serverless-iam-roles-per-function": "2.0.2",

That doesn't work in my case

from serverless-iam-roles-per-function.

Ran into this issue as well.
We were able to find a temporary workaround by locking the version of serverless framework installed to a previous version.
npm i [email protected] -g

This is the only workaround which worked for me for now.

from serverless-iam-roles-per-function.

Same problem here .

from serverless-iam-roles-per-function.

same problem here .

from serverless-iam-roles-per-function.

Hi, sorry for being non responsive. I will take a look at the PR.

As I am currently limited in time for the project, I am looking to add an additional maintainer for the project. If someone is interested please let me know.

from serverless-iam-roles-per-function.

@glicht The same for me. Contribution in portfolio #25

from serverless-iam-roles-per-function.

@glicht Even updating to @next, I see this:

Serverless: Configuration warning:
Serverless: at 'functions.rulesSeedQueue': unrecognized property 'iamRoleStatements'
Serverless: at 'functions.rulesDisable': unrecognized property 'iamRoleStatements'
Serverless: at 'functions.rulesFetchAndExecute': unrecognized property 'optimize'
Serverless: at 'functions.rulesFetchAndExecute': unrecognized property 'iamRoleStatements'
Serverless: at 'functions.pricingInsert': unrecognized property 'iamRoleStatements'
Serverless: at 'functions.pricingUpdate': unrecognized property 'iamRoleStatements'
Serverless:
Serverless: Learn more about configuration validation here: http://slss.io/configuration-validation

And

Serverless Error ---------------------------------------

An error occurred: RulesSeedQueueIamRoleLambdaExecution - The policy failed legacy parsing (Service: AmazonIdentityManagement; Status Code: 400; Error Code: MalformedPolicyDocument; Request ID: 16349a14-d7e1-4fd6-bb3e-383aac6add83; Proxy: null).

The app in question had worked fine until updating to latest Serverless, no changes have been made. Nothing is being created at all in AWS. Here's my config: https://gist.github.com/davidfells/681ffb43a42a73da0522c2df69692d34

from serverless-iam-roles-per-function.

npm i serverless-iam-roles-per-function@next

from serverless-iam-roles-per-function.